fix: networklog can throw exception when no networkmanager exists - #3917
Merged
NoelStephensUnity merged 8 commits intoMar 30, 2026
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixing exception that could be thrown in NetworkLog if there is no NetworkManager instance. Adding additional check in NetworkObject.OnNetworkBehaviourDestroyed to assure nothing is ever logged about destroying a NetworkBehaviour when shutting down and the NetworkObject is still considered spawned.
NoelStephensUnity
enabled auto-merge (squash)
March 24, 2026 17:36
Comment thread
com.unity.netcode.gameobjects/Runtime/Logging/NetworkLog.cs
…etworkmanager-exists
…etworkmanager-exists
noellie-velez
approved these changes
Mar 27, 2026
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Looks good to me! 🚀
Sorry, something went wrong.
noellie-velez
self-requested a review
March 27, 2026 13:11
noellie-velez
approved these changes
Mar 27, 2026
EmandM
approved these changes
Mar 30, 2026
NoelStephensUnity
deleted the
fix/networklog-can-throw-exception-when-no-networkmanager-exists
branch
March 30, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The purpose of this PR is to resolve the issue where attempting to use NetworkLog when there is no NetworkManager instance would result in an exception.
Jira ticket
MTT-14743
fix: #3911
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Automated tests:
Does the change require QA team to:
If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No backport is required.