fix: Support InLocalSpace in AnticipatedNetworkTransform - #3995
Merged
ShadauxCat merged 9 commits intoJul 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
EmandM
reviewed
May 22, 2026
EmandM
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This looks great! I especially like the duplication of the updates for WaitForConditionOrTimeout for the time travel tests.
Sorry, something went wrong.
| } | ||
|
|
||
| transform_.SetPositionAndRotation(Transform.m_AnticipatedTransform.Position, Transform.m_AnticipatedTransform.Rotation); | ||
| if (Transform.InLocalSpace) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think it's worth having a function for SetPositionAndRotation that does this logic internally. We're using it a lot in this file, having a function will mean any future developers in this file won't have to remember about InLocalSpace.
Sorry, something went wrong.
EmandM
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes AnticipatedNetworkTransform not respecting the InLocalSpace flag
fixes #2972
Jira ticket
UUM-137286
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Automated tests:
Does the change require QA team to:
If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports