fix: Message sending GC allocations - #4119
Merged
EmandM merged 6 commits intoAug 11, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## develop-2.0.0 #4119 +/- ##
=================================================
+ Coverage 73.88% 73.94% +0.06%
=================================================
Files 172 172
Lines 28095 28099 +4
=================================================
+ Hits 20758 20779 +21
+ Misses 7337 7320 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
Sorry, something went wrong.
NoelStephensUnity
approved these changes
Aug 11, 2026
NoelStephensUnity
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good!
👍
Sorry, something went wrong.
ShadauxCat
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes some GC allocations in message hot paths.
Jira ticket
fixes: #4091
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Automated tests:
Does the change require QA team to:
If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Up-port
Up-port needed
Backports
n/a