trunk shadow changes: com.unity.netcode.gameobjects - #4120
Conversation
Sorry, something went wrong.
|
|
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-2.0.0 #4120 +/- ##
=================================================
+ Coverage 73.86% 73.92% +0.05%
=================================================
Files 172 172
Lines 28099 28099
=================================================
+ Hits 20756 20772 +16
+ Misses 7343 7327 -16
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes
|
Sorry, something went wrong.
EmandM
left a comment
There was a problem hiding this comment.
I'm approving the C# changes, but I think @michalChrobot you'll want to take a look at the change in manifest_update.py. It looks like an unrelated change but I'm not sure.
Sorry, something went wrong.
|
Yeah, I'm taking a look now (need to resolve the merge conflict + script compilation failure) |
Sorry, something went wrong.
|
|
||
|
|
||
| [UnityTest] | ||
| [UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149592", "NGO NetworkVariable serialization codegen not generated for some types on CoreCLR (falls back to FallbackSerializer)")] |
There was a problem hiding this comment.
Interesting issue here because UnityCoreClrExplicitDisabled is trunk specific and doesn't exist in our repo. I will investigate how to add this
Sorry, something went wrong.
There was a problem hiding this comment.
It should be fixed now, I will see once the job pass if it works correctly (those tests should run as usual in our current testing)
Sorry, something went wrong.
…tDisabledAttributeShim.cs to make attribute usage possible
* Updated changelog and package version for Netcode in anticipation of v2.13.1 release * typo in build automation * trunk shadow changes: com.unity.netcode.gameobjects [skip ci] * Revert CHANGELOG changes * Added UNITY_TEST_FRAMEWORK_1_7_OR_NEWER guard and UnityCoreClrExplicitDisabledAttributeShim.cs to make attribute usage possible * corrected svc bot exclusion --------- Co-authored-by: netcode-automation <svc-netcode-sdk@unity3d.com> Co-authored-by: Michał Chrobot <michal.chrobot@unity3d.com> Co-authored-by: PETS automation <299490404+pets-svc[bot]@users.noreply.github.com> Co-authored-by: Emma <emma.mcmillan@unity3d.com>
This PR contains changes made to the trunk copy of com.unity.netcode.gameobjects.
This usually means that breaking changes has landed in the trunk Editor, necessitating matching changes to your package code. trunk is therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.
The bot commit was created on top of the package release commit, and so this PR contains unrelated older commits. You may need to change the PR target branch (by clicking the pencil icon next to the PR title), or cherrypick the commit to a freshly created branch.
Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.
Note: The shadow-package/com.unity.netcode.gameobjects branch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:
If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened.