| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Adding an additional unified hybrid spawning test pass.
Fixed: - Issue with NetworkObject throwing an exception during hybrid integration test. - Issue with setting the active world prior to spawning a hybrid prefab during integration tests. - Issue with UnifiedNetcodeUpdateSystem not overriding the OnCreate method along with checks for a valid NetworkManager and/or transport within OnUpdate. - Issues (minor) with the original UnifiedNetworkTransformTest. - Adjustments to the NetcodeIntegrationTest that assures the correct active world is assigned when spawning.
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
…est filter Unified selection now lives in C# instead: - unified-tests.yml sets UNIFIED_TESTS=true and passes no --testfilter; unified_test_filter is removed from project.metafile. - NetcodeIntegrationTest.UseUnifiedTests() (virtual, defaults to false) is the opt-in a fixture overrides to run in a unified pass. USE_CMB_SERVICE still takes precedence. - Adds IgnoreIfUnifiedTestsEnvironmentVariableSetAttribute and the matching NetcodeIntegrationTestHelpers.IgnoreIfUnifiedTestsEnvironmentVariableSet() so fixtures that do not apply under unified netcode opt out explicitly. - Applies that opt-out across the package and testproject fixtures that do not need to run against hybrid prefabs.
Removed comments regarding unified tests and their dependencies.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-3.x.x #4137 +/- ##
==============================================
Coverage 78.00% 78.00%
==============================================
Files 153 153
Lines 26260 26260
==============================================
Hits 20483 20483
Misses 5777 5777
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sorry, something went wrong.
…environment-var develop-3.x.x now carries PR #4122 as a single squashed commit, so the four unified files this branch also changes conflicted against their own squashed history rather than against new work. Conflict resolutions: - .yamato/project.metafile: kept this branch's deletion of unified_test_filter. The squash reintroduced it; selection is the UNIFIED_TESTS environment variable plus NetcodeIntegrationTest.UseUnifiedTests now. - .yamato/unified-tests.yml: kept this branch's version, which is the same job with the UNIFIED_TESTS variable and no --testfilter. - .yamato/_triggers.yml: took develop-3.x.x (drops a stray blank line). - NetcodeIntegrationTest.cs: took develop-3.x.x's TODO-UNIFIED tag rename. Incoming: the SceneManagementSynchronizationTests rework that distinguishes scene events from connection events and adjusts the m_UseCmbService path, which is the CMB service test fix, plus the U-PR bot config.
There was a problem hiding this comment.
The change introduces environment-driven selection for unified hybrid test jobs and corrects the hybrid configuration messages, but the new method-parameter filtering path cannot support the opt-in route it documents.
Reviewed commit 9c79cb9
🤖 Helpful? 👍/👎
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Purpose of this PR
Base branch: chore/enable-unified-hybrid-tests (#4122) — not develop-3.x.x — merge #4122 before this.
Follow-up to #4122, which added the unified (NGO + N4E) hybrid prefab test job. That first step
selected which tests ran by passing a name pattern to UTR (unified_test_filter). This PR replaces
that pattern with test selection defined in C#, so the YAML no longer decides what runs.
This is the first part of 3 PRs:
What replaces the test filter from 4122. The job now sets UNIFIED_TESTS: "true" and passes no --testfilter
(unified_test_filter is deleted from project.metafile). NetcodeIntegrationTest applies three
rules, all under #if UNIFIED_NETCODE, so nothing changes when N4E is absent:
Supporting pieces:
parameter rather than a fixture argument. OneTimeSetup runs once per fixture and cannot see a
method parameter, so those fixtures call this themselves before starting any instances.
NetworkVariableTests is the case in this PR.
NetcodeIntegrationTestHelpers.IgnoreIfUnifiedTestsEnvironmentVariableSet() for fixtures that do
not derive from NetcodeIntegrationTest. The attribute respects RunState.NotRunnable first so it
cannot resurrect a test another attribute already excluded.
same run, so a CMB service pass forces unified off.
GetUnifiedTestsEnvironmentVariable() also honours a UNIFIED_TESTS compile define, which is what
makes a local run possible without setting the variable in the editor's environment.
saying to remove the opt-out if the test is later updated to support them.
Also in here: two missing $ prefixes on interpolated Log.Error strings in
NetworkManager.UnifiedIsConfiguredCorrectly, which were logging a literal {nameof(NetCodeConfig)}.
Jira ticket
MTT-XXXX
Changelog
Not relevant — CI and test-infrastructure only. The one runtime edit is an error-message fix in
unified code that is not yet publicly released.
Documentation
The reasoning that used to live in the project.metafile comment block now lives with the code it
governs: the UseUnifiedTests and ApplyUnifiedTestFilter XML docs explain why hybrid prefab cases
are opt-in and why a method-parameter HostOrServer needs separate handling.
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual tests:
Automated tests:
The change is itself test infrastructure, so the verification is the shape of the run rather than a
new test: in a unified pass, UnifiedNetworkTransformTest runs and everything else reports as
ignored with one of the three reasons above; in a normal pass, nothing is ignored and the suite
behaves exactly as it did before this PR. Both are visible in the UTR results XML.
Does the change require QA team to:
Up-port
Not needed. This targets the #4122 branch on the develop-3.x.x line, and the unified API exists
only there.
Backports
Not needed, same reason.