Hot Load and Chunked Save of Demo Files - #5455
Open
ervteng wants to merge 11 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
ervteng
marked this pull request as ready for review
August 19, 2021 01:30
miguelalonsojr
requested review from
miguelalonsojr
and removed request for
vincentpierre
January 18, 2022 23:43
Copy link
Copy Markdown
|
Ervin Teng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Adds two new IL improvements: allow for adding additional .demo files during a training run, and saves new demos from the DemonstrationWriter in chunks of Num Steps to Record size.
You can combine these two features to do online IL by pointing the writer and the GAIL/BC YAML to the same folder, but no explicit way of doing online has been added.
Also fixed a longstanding bug that if multiple demo files are in a folder, they are all treated as one long appended file, which is not correct as the final obs/action pair will be joined with the first one from the next file.
Types of change(s)
Checklist
Other comments