Uni 55420 build multi platform dll - #2
Merged
vkovec merged 6 commits intoAug 10, 2018
Merged
vkovec merged 6 commits into
vkovec merged 6 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- so that the platform is decided at runtime instead of compile time
- easier to check which OS we are on
lassond
reviewed
Aug 9, 2018
Comment thread
src/runtime/runtime.cs
| return res; | ||
| } | ||
|
|
||
| public static IntPtr dlopen(String fileName, int flags) |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
It looks like a Windows application could call dl{open,sym,close,...}. I saw the code above never does it on Windows but should you throw an exception if the platform is windows?
Sorry, something went wrong.
lassond
approved these changes
Aug 9, 2018
lassond
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Small comment on dlopen and other dl* functions. Apart from that it looks good
Sorry, something went wrong.
- throw exception if trying to call Mac/Linux specific functions on Windows - fix dllBase path to point into packages
lassond
approved these changes
Aug 10, 2018
BadSingleton
pushed a commit
that referenced
this pull request
Sep 10, 2020
…mments Soft shutdown review comments
BadSingleton
pushed a commit
that referenced
this pull request
Jan 24, 2022
Reworked `ManagedType` to not keep python references to self
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
build dll that works on multiple platforms. Requires rename of python .dylib on mac from libpython2.7.dylib to libpython27.dylib
...
Does this close any currently open issues?
...
Any other comments?
...
Checklist
Check all those that are applicable and complete.