FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Correct label for persistent object cache Site Health check by mukeshpanchal27 · Pull Request #329 · WordPress/performance · GitHub

/ performance Public

Correct label for persistent object cache Site Health check - #329

Merged
felixarntz merged 2 commits into
WordPress:trunkfrom
mukeshpanchal27:fix/label-persistent-object-cache
May 10, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Correct label for persistent object cache Site Health check#329
felixarntz merged 2 commits into
WordPress:trunkfrom
mukeshpanchal27:fix/label-persistent-object-cache

Conversation

mukeshpanchal27 commented May 9, 2022 •
edited by felixarntz
Loading

Copy link
Copy Markdown
Member

Fixes #328

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

mxbclang added [Type] Bug An existing feature is broken [Focus] Object Cache no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature and removed [Type] Bug An existing feature is broken labels May 9, 2022
tillkruss added [Type] Bug An existing feature is broken and removed [Type] Enhancement A suggestion for improvement of an existing feature labels May 9, 2022
tillkruss added this to the 1.1.0 milestone May 9, 2022
felixarntz reviewed May 9, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mukeshpanchal27 One small thing to address here, other than that lgtm.

Comment thread modules/object-cache/persistent-object-cache-health-check/load.php Outdated
mukeshpanchal27 mentioned this pull request May 10, 2022
Merged
3 tasks
felixarntz approved these changes May 10, 2022
View reviewed changes

felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @mukeshpanchal27!

felixarntz merged commit 7e336d0 into WordPress:trunk May 10, 2022
felixarntz changed the title Correct persistent object cache label Correct label for persistent object cache Site Health check May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

spacedmonkey spacedmonkey approved these changes
tillkruss tillkruss approved these changes
felixarntz felixarntz approved these changes

Assignees

felixarntz

Labels

no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

Correct persistent object cache label

6 participants

Back | FazBrowse Home | New Git URL