Avoid unnecessarily early escape of Site Health check labels - #332
Merged
felixarntz merged 3 commits intoMay 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mukeshpanchal27
requested review from
adamsilverstein,
kirtangajjar,
manuelRod and
mitogh
as code owners
May 10, 2022 16:57
felixarntz
approved these changes
May 10, 2022
felixarntz
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Great, thank you @mukeshpanchal27!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@mukeshpanchal27 I've updated the base branch to release/1.1.0, with the goal to get this into the upcoming release. Can someone else please approve this by tomorrow? cc @adamsilverstein @manuelRod @kirtangajjar @mitogh @tillkruss 🙌 |
Sorry, something went wrong.
mitogh
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @felixarntz in the #329 ticket.
Checklist