FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Migrate TieredInt wire sizes to pinned ae-numeric by NikolayChirkov · Pull Request #540 · aethernetio/aether-client-cpp · GitHub

/ aether-client-cpp Public

Migrate TieredInt wire sizes to pinned ae-numeric - #540

Merged
NikolayChirkov merged 4 commits into
mainfrom
feature/migrate-ae-numeric
Aug 25, 2026
ConversationCommits (4)ChecksFiles changed
Merged

Migrate TieredInt wire sizes to pinned ae-numeric#540
NikolayChirkov merged 4 commits into
mainfrom
feature/migrate-ae-numeric

Conversation

NikolayChirkov commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Migrate legacy TieredInt to pinned ae-numeric (68fcbb3) with target ae-numeric.
  • Preserve the existing wire protocol byte-for-byte (no framing/endian/tier-boundary changes).
  • Canonical size type: PackedSize = TieredInt<uint8_t, 250, 1514, 1049834> (PacketSize alias).
  • Migrate serializers to the wire_traits / Serialize / Deserialize / WireBytesNeeded API.
  • Packet and message framing remain unchanged; replace sizeof(ValueType) overhead uses with kMaxWireBytes.
  • Add golden boundary tests and fragmented 1/2/4/8-byte header collection tests.
  • MSVC Release binary size slightly decreased vs origin/main (aether.lib −15 154, ab-message-exchange.exe −1 024).
  • Pin migrated aether-tele at 7424eb5 and remove the temporary aether-tele-ae-numeric.patch (tele migration: aether-tele PR #5).

Test plan

  • Aether CI: Windows MSVC (x64/x86 × Hydrogen/Sodium)
  • Aether CI: Windows MinGW (Hydrogen/Sodium)
  • Aether CI: Ubuntu GCC (Hydrogen/Sodium)
  • Aether CI: macOS Clang (Hydrogen/Sodium)
  • Aether CI: cppcheck + release aggregator
  • Aether CI: ESP-IDF latest for esp32 cloud (passed on CI)
  • test-transport (includes golden + fragmented header tests) passed in CI matrix
  • No production numeric/tiered_int.h, TierDeserializeRes, old 3-param TieredInt, or tele patch
  • No accidental text_io / ostream_io includes
  • Known local note (untouched in this PR): with ESP-IDF 5.4 locally, esp_wifi_driver.cpp can fail on ESP_LOGI(... "%d", int32_t) under -Werror=format. That is unrelated to the numeric migration and was not changed here. CI ESP-IDF latest is green.

NikolayChirkov and others added 2 commits August 24, 2026 13:05
Migrate Aether wire sizes to pinned ae-numeric TieredInt.
b352b66 
Replace legacy numeric TieredInt with ae::PackedSize/PacketSize backed by
ae-numeric@b82a367, keep packet/message framing byte-identical, and cover
golden plus fragmented header cases in Aether tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
Drop aether-tele ae-numeric patch; pin migrated tele.
1ae3eb8 
aether-tele@4aa5666 already uses ae-numeric, so remove the temporary
PATCHES workaround and pin that commit instead of floating main.
Pin ae-numeric/tele with C4702 fixes; drop MSVC /wd4702.
6eb4bd4 
Co-authored-by: Cursor <cursoragent@cursor.com>
BartolomeyKant requested changes Aug 25, 2026
View reviewed changes
Comment thread aether/packed_size.h Outdated
Move PackedSize into types/ and pin updated numeric/tele.
cdcc6ed 
Co-authored-by: Cursor <cursoragent@cursor.com>
NikolayChirkov merged commit 35da38d into main Aug 25, 2026
14 checks passed
NikolayChirkov deleted the feature/migrate-ae-numeric branch August 25, 2026 17:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BartolomeyKant BartolomeyKant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL