FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Cursor component: improve xrselect rayOrigin logic by mrxz · Pull Request #5606 · aframevr/aframe · GitHub

Cursor component: improve xrselect rayOrigin logic - #5606

Merged
dmarcos merged 2 commits into
aframevr:masterfrom
mrxz:cursor-xr-fix
Nov 15, 2024
Merged

Cursor component: improve xrselect rayOrigin logic#5606
dmarcos merged 2 commits into
aframevr:masterfrom
mrxz:cursor-xr-fix

Conversation

mrxz commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

Description:
Continuation of #5528 adding logic to convert the XRPose coming from WebXR into world space. Intended usage of cursor="rayOrigin: xrselect" is to place it on the a-scene (similar to rayOrigin: mouse), but can also be placed elsewhere as the logic no longer depends on the entity it is on.

Changes proposed:

  • Add and remove WebXR event listeners when changing rayOrigin type to/from xrselect and when entering/leaving XR
  • Convert the WebXR pose to world space accounting for any camera rig
  • Handle the case no pose is available (before tracking is established or when temporarily lost)
  • Fixed a bug where a selectend from a different input source would incorrectly reset the activeXRInput freezing the active input source.

dmarcos commented Nov 15, 2024

Copy link
Copy Markdown
Member

Thank you!

dmarcos merged commit 655ab16 into aframevr:master Nov 15, 2024

dmarcos commented Nov 16, 2024

Copy link
Copy Markdown
Member

Tested this on Vision Pro and seems to work as expected. Thanks

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL