FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added some tests in test_learning.py by agarwl · Pull Request #293 · aimacode/aima-python · GitHub

  1. aimacode
  2. aima-python

Repository navigation

Added some tests in test_learning.py - #293

Merged
norvig merged 2 commits into
aimacode:masterfrom
agarwl:patch-1
May 31, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Added some tests in test_learning.py#293
norvig merged 2 commits into
aimacode:masterfrom
agarwl:patch-1

Conversation

agarwl commented Mar 1, 2017 •
edited
Loading

Copy link
Copy Markdown

Added tests for the error functions in learning.py as required by #286 .
@reachtarunhere, What kind of other tests can be added?

sampadsaha5 reviewed Mar 1, 2017
View reviewed changes
Comment thread tests/test_learning.py

def test_weighted_replicate():
assert weighted_replicate('ABC', [1, 2, 1], 4) == ['A', 'B', 'B', 'C']

sampadsaha5 Mar 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I really appreciate your work. There is just a small mistake.
You are required to import rms_error(), manhattan_distance(), mean_boolean_error() and mean_error() from learning.

agarwl Mar 2, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done!

agarwl mentioned this pull request Mar 1, 2017
Closed

norvig commented Mar 3, 2017

Copy link
Copy Markdown
Member

Now there is a conflict in learning.py

agarwl commented Mar 3, 2017

Copy link
Copy Markdown
Author

Actually I have already resolved the issue #295 in this pull request in addition to adding the tests. I referenced that commit in the issue too.

vidursatija commented Mar 3, 2017

Copy link
Copy Markdown
Contributor

I didn't know you resolved the issue #295 in your pull request. I independently resolved it. Sorry for any inconvenience caused.

agarwl closed this Mar 3, 2017
agarwl reopened this Mar 3, 2017
agarwl force-pushed the patch-1 branch 2 times, most recently from 01700a5 to 6368474 Compare March 3, 2017 19:22
agarwl mentioned this pull request Mar 3, 2017
Closed
agarwl changed the title Added some unittests in test_learning.py Added some tests in test_learning.py Mar 3, 2017

Chipe1 commented Mar 8, 2017

Copy link
Copy Markdown
Contributor

@TheSPARTA Could you break this PR into 2 parts, 1 which resolves the mistake in count() and one which adds test cases after resolving the conflicts. You can aslo uncomment the mean_boolean_error() test cases as the bug seems to be fixed

Chipe1 mentioned this pull request Apr 1, 2017
Closed
norvig merged commit 2bba02e into aimacode:master May 31, 2017
dj5x5 pushed a commit to dj5x5/aima-python that referenced this pull request Jul 17, 2025
Added some unittests in test_learning.py (aimacode#293)
16f2a52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
sampadsaha5 sampadsaha5 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL