Add new tests to learning.py - #458
Closed
lucasmoura wants to merge 1 commit into
Closed
lucasmoura wants to merge 1 commit into
lucasmoura wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Most of the tests were already added in #293. Line 60 throws "AttributeError: 'module' object has no attribute 'approx'" when running py.test |
Sorry, something went wrong.
sofmonk
reviewed
Apr 1, 2017
Comment thread
tests/test_learning.py
| predictions = [1, 1, 2, 1] | ||
| targets = [1, 2, 1, 1] | ||
|
|
||
| assert rms_error(predictions, targets) == pytest.approx(sqrt(0.5)) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
pytest will have to be removed.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@Chipe1 Thanks for pointing out about the other MR request. I have also realized that I am using a newer version of py.test than the one in the build. But since there is another MR covering the same tests as these ones, I will close it for now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for the following functions in learning.py