Repository navigation
fix(router): fall back when serializing protocol-relative URLs - #71094
Merged
kirjs merged 1 commit intoOct 2, 2026
Merged
kirjs merged 1 commit into
kirjs merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
alan-agius4
reviewed
Sep 30, 2026
Comment thread
packages/router/src/url_tree.ts
Outdated
atscott
force-pushed
the
fix/router-relative-url
branch
2 times, most recently
from
aa3c990 to
e8098db
Compare
September 30, 2026 16:18
Avoid throwing when DefaultUrlSerializer encounters a UrlTree that would serialize to a protocol-relative URL. Warn in development mode and serialize the tree with a root-relative path instead while preserving query parameters and fragments. Additionally, account for WHATWG URL normalization (e.g. dot segments and backslashes collapsing into protocol-relative paths such as `/.//` or `/..//`). Fixes angular#69700 Fixes angular#71076 Co-authored-by: Andrew Scott <atscott01@gmail.com>
atscott
force-pushed
the
fix/router-relative-url
branch
from
e8098db to
f10507e
Compare
September 30, 2026 17:14
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
kirjs
approved these changes
Oct 2, 2026
Copy link
Copy Markdown
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches: |
Sorry, something went wrong.
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid throwing when DefaultUrlSerializer encounters a UrlTree that would serialize to a protocol-relative URL. Warn in development mode and serialize the tree with a root-relative path instead while preserving query parameters and fragments.
Additionally, account for WHATWG URL normalization (e.g. dot segments and backslashes collapsing into protocol-relative paths such as /.// or /..//).
Fixes #69700
Fixes #71076