FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(router): fall back when serializing protocol-relative URLs by atscott · Pull Request #71143 · angular/angular · GitHub

Repository navigation

fix(router): fall back when serializing protocol-relative URLs - #71143

Open
atscott wants to merge 1 commit into
angular:20.3.xfrom
atscott:fix-protocol-relative-20.3.x
Open

atscott wants to merge 1 commit into
angular:20.3.xfrom
atscott:fix-protocol-relative-20.3.x

Conversation

atscott commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Backports #71094 to 20.3.x.

Avoid throwing when DefaultUrlSerializer encounters a UrlTree that would serialize to a protocol-relative URL. Warn in development mode and serialize the tree with a root-relative path instead while preserving query parameters and fragments.

Additionally, account for WHATWG URL normalization (e.g. dot segments and backslashes collapsing into protocol-relative paths such as /.// or /..//).

Fixes #69700
Fixes #71076

Avoid throwing when DefaultUrlSerializer encounters a UrlTree that would serialize to a protocol-relative URL. Warn in development mode and serialize the tree with a root-relative path instead while preserving query parameters and fragments.

Additionally, account for WHATWG URL normalization (e.g. dot segments and backslashes collapsing into protocol-relative paths such as `/.//` or `/..//`).

Fixes angular#69700
Fixes angular#71076

Co-authored-by: Andrew Scott <atscott01@gmail.com>
pullapprove Bot requested review from crisbeto and mmalerba October 2, 2026 16:08
ngbot Bot added this to the Backlog milestone Oct 2, 2026
atscott added target: lts This PR is targeting a version currently in long-term support state: blocked labels Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: router state: blocked target: lts This PR is targeting a version currently in long-term support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL