Revert "fix(@angular-devkit/build-angular): control linker template sourcemapping via builder sourcemap options" - #21284
Merged
clydin merged 3 commits intoJul 6, 2021
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
alan-agius4
force-pushed
the
revert-21155-linker/vendor-sourcemaps
branch
from
9ca89d9 to
1395997
Compare
July 5, 2021 07:17
…ourcemapping via builder sourcemap options" This reverts commit d4c5f85. Following a debugging and investigation with @petebacondarwin it appears that when the external template handling in the linker generates Babel AST nodes that reference the external template files which breaks Babel when it tried to flatten final source-map, which ends up no emitting any source-maps. As an interim solution we should revert this. Closes #21271
alan-agius4
force-pushed
the
revert-21155-linker/vendor-sourcemaps
branch
from
1395997 to
da74c6e
Compare
July 5, 2021 07:24
Copy link
Copy Markdown
Collaborator
Author
|
Related issue in FW angular/angular#42769 |
Sorry, something went wrong.
petebacondarwin
approved these changes
Jul 5, 2021
Copy link
Copy Markdown
Contributor
|
Is it possible to create a test that demonstrated that the source-map for the library is created after this revert? |
Sorry, something went wrong.
alan-agius4
force-pushed
the
revert-21155-linker/vendor-sourcemaps
branch
from
4b70d32 to
9109cdc
Compare
July 6, 2021 14:04
…on to false. This is an interim solution until angular/angular#42769 is fixed. Closes #21271
alan-agius4
force-pushed
the
revert-21155-linker/vendor-sourcemaps
branch
from
9109cdc to
88737e3
Compare
July 6, 2021 14:12
clydin
approved these changes
Jul 6, 2021
Copy link
Copy Markdown
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #21155
Following a debugging and investigation with @petebacondarwin it appears that when the external template handling in the linker generates Babel AST nodes that reference the external template files which breaks Babel when it tried to flatten final source-map, which ends up no emitting any source-maps.
As an interim solution we should revert this.
Closes #21271