FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix($location): absUrl() does not return undefined for base href and … by rvpatkar · Pull Request #14085 · angular/angular.js · GitHub

This repository was archived by the owner on Apr 12, 2024. It is now read-only.
  1. angular
  2. angular.js

Repository navigation

fix($location): absUrl() does not return undefined for base href and … - #14085

Closed
rvpatkar wants to merge 1 commit into
angular:masterfrom
rvpatkar:absoluteUrlFix2
ConversationCommits (1)ChecksFiles changed
Closed

fix($location): absUrl() does not return undefined for base href and …#14085
rvpatkar wants to merge 1 commit into
angular:masterfrom
rvpatkar:absoluteUrlFix2

Conversation

rvpatkar commented Feb 19, 2016

Copy link
Copy Markdown

…html5Mode

$location's absUrl incorrectly returned undefined when using base href and html5Mode. Initializaing it to fix this issue.

Closes #11091

fix($location): absUrl() does not return undefined for base href and …
d1f576b 
…html5Mode

$location's absUrl incorrectly returned undefined when using base href and html5Mode. Initializaing it to fix this issue.

Closes angular#11091

googlebot commented Feb 19, 2016

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment

googlebot commented Feb 19, 2016

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

rvpatkar commented Feb 19, 2016

Copy link
Copy Markdown
Author

I signed it!

googlebot commented Feb 19, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment

googlebot commented Feb 19, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

gkalpak commented Feb 19, 2016

Copy link
Copy Markdown
Member

Thx for the PR, but there needs to be at least one test (verifying the fix and guarding against future regressions), before we can merge this.

TBH, I'm not even sure what issue this PR fixes.

gkalpak added this to the Purgatory milestone Feb 19, 2016
gkalpak self-assigned this Feb 19, 2016

gkalpak commented Jun 3, 2016

Copy link
Copy Markdown
Member

Closing in favor of #14488 (which also includes a test).

gkalpak closed this Jun 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

gkalpak

Labels

cla: yes component: $location needs: more info needs: test

Projects

None yet

Milestone

Purgatory

Development

Successfully merging this pull request may close these issues.

$location.absUrl() returns undefined with base href and html5Mode

3 participants

Back | FazBrowse Home | New Git URL