FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix($location) : initialize locationPrototype.$$absUrl to empty string by GuillaumeSalles · Pull Request #14488 · angular/angular.js · GitHub

This repository was archived by the owner on Apr 12, 2024. It is now read-only.
  1. angular
  2. angular.js

Repository navigation

fix($location) : initialize locationPrototype.$$absUrl to empty string - #14488

Closed
GuillaumeSalles wants to merge 1 commit into
angular:v1.4.xfrom
GuillaumeSalles:fix-location-service-when-external-base-path
ConversationCommits (1)ChecksFiles changed
Closed

fix($location) : initialize locationPrototype.$$absUrl to empty string#14488
GuillaumeSalles wants to merge 1 commit into
angular:v1.4.xfrom
GuillaumeSalles:fix-location-service-when-external-base-path

Conversation

GuillaumeSalles commented Apr 21, 2016

Copy link
Copy Markdown

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Initialize locationPrototype.$$absUrl to avoid a crash when base href and current location have different domains.

What is the current behavior? (You can also link to an open issue here)
#11091

What is the new behavior (if this is a feature change)?
Does not crash anymore.

Does this PR introduce a breaking change?
I don't think so...

Please check if the PR fulfills these requirements

Other information:

Closes #11091

fix($location) : initialize locationPrototype.$$absUrl to empty string
1af5286 
Initialize locationPrototype.$$absUrl to avoid exception when base href
and current location have different dommains.

Closes #11091

googlebot commented Apr 21, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment

googlebot commented Apr 21, 2016

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

GuillaumeSalles commented Apr 21, 2016

Copy link
Copy Markdown
Author

Hi, I just signed the CLA.

gkalpak commented Apr 22, 2016

Copy link
Copy Markdown
Member

Seems reasonable, but one can never be too sure with $location stuff 😛
/cc @petebacondarwin for the final LGTM

(The CLA thing doesn't seem to have worked btw...)

GuillaumeSalles commented Apr 22, 2016

Copy link
Copy Markdown
Author

I signed the CLA with another account. My mistake.
I just signed it again with the right email.

googlebot commented Apr 22, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment

googlebot commented Apr 22, 2016

Copy link
Copy Markdown

CLAs look good, thanks!

Narretz added this to the Backlog milestone Apr 28, 2016
gkalpak mentioned this pull request May 24, 2016
Closed

gkalpak commented Jun 3, 2016

Copy link
Copy Markdown
Member

This should also fix #13565.

This was referenced Jun 3, 2016
Closed
Closed

petebacondarwin commented Jun 6, 2016

Copy link
Copy Markdown
Contributor

LGTM

gkalpak closed this in b9ac336 Jun 6, 2016
gkalpak pushed a commit that referenced this pull request Jun 6, 2016
fix($location) : initialize $$absUrl to empty string
294d679 
Initialize `$$absUrl` to an empty string, in order to avoid exception, when base href
and current location have different domains.

Fixes #11091
Fixes #13565

Closes #14488
keturn mentioned this pull request Sep 25, 2017
Open
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes component: $location type: bug

Projects

None yet

Milestone

Backlog - won't fix

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL