FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(material/form-field): update outline gap when prefix changes by crisbeto · Pull Request #23869 · angular/components · GitHub

fix(material/form-field): update outline gap when prefix changes - #23869

Merged
amysorto merged 1 commit into
angular:masterfrom
crisbeto:23863/form-field-prefix-change
Nov 8, 2021
Merged

fix(material/form-field): update outline gap when prefix changes#23869
amysorto merged 1 commit into
angular:masterfrom
crisbeto:23863/form-field-prefix-change

Conversation

crisbeto commented Nov 2, 2021

Copy link
Copy Markdown
Member

The position of the outline gap depends on the size of the prefix, but we weren't set up to update it when that happens.

Fixes #23863.

crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 2, 2021
crisbeto requested a review from devversion November 2, 2021 06:04
crisbeto requested a review from mmalerba as a code owner November 2, 2021 06:04
google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2021

crisbeto commented Nov 2, 2021

Copy link
Copy Markdown
Member Author

Browserstack failure will be resolved by #23870.

crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2021
The position of the outline gap depends on the size of the prefix, but we weren't set up to update it when that happens.

Fixes angular#23863.
crisbeto force-pushed the 23863/form-field-prefix-change branch from 93a8d48 to a460856 Compare November 2, 2021 17:30
amysorto merged commit a6d4141 into angular:master Nov 8, 2021
amysorto pushed a commit that referenced this pull request Nov 8, 2021
)

The position of the outline gap depends on the size of the prefix, but we weren't set up to update it when that happens.

Fixes #23863.

(cherry picked from commit a6d4141)

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(mat-form-field): label is not within the border gap for outline appearance

3 participants


Back | FazBrowse Home | New Git URL