FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test(material/select): fix failing unit test by crisbeto · Pull Request #23870 · angular/components · GitHub

test(material/select): fix failing unit test - #23870

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:select-test-failure
Nov 2, 2021
Merged

test(material/select): fix failing unit test#23870
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:select-test-failure

Conversation

crisbeto commented Nov 2, 2021

Copy link
Copy Markdown
Member

Fixes a unit test that started failing, because it tries to scroll the page down, but there isn't enough content for it to scroll.

Fixes a unit test that started failing, because it tries to scroll the page down, but there isn't enough content for it to scroll.
google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 2, 2021
crisbeto added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Nov 2, 2021
crisbeto marked this pull request as ready for review November 2, 2021 09:01
crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2021
jelbourn merged commit 94aa7d3 into angular:master Nov 2, 2021
jelbourn pushed a commit that referenced this pull request Nov 2, 2021
Fixes a unit test that started failing, because it tries to scroll the page down, but there isn't enough content for it to scroll.

(cherry picked from commit 94aa7d3)
jelbourn pushed a commit that referenced this pull request Nov 2, 2021
Fixes a unit test that started failing, because it tries to scroll the page down, but there isn't enough content for it to scroll.

(cherry picked from commit 94aa7d3)

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL