| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
When Task subagents create child sessions, they are not registered in the ACP session manager. This caused permission requests from those sessions to be silently ignored, freezing the session indefinitely. Now fetches session info from SDK when the session is not found in the manager, allowing permission requests from child sessions to be properly forwarded to the ACP client.
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Sorry, something went wrong.
|
I think the checks are flaky/unrelated to my changes. Just a note from a previous thread - I wonder if we need to address sub-subagents. Right now I believe this only covers subagents and we will have the same behavior from sub-subagents. Do we want to fix this so it recursively walks up the .parent until it finds a valid session? |
Sorry, something went wrong.
|
I believe #13222 resolved this. will leave just in case |
Sorry, something went wrong.
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
When Task subagents create child sessions, they are not registered in the ACP session manager. This caused permission requests from those sessions to be silently ignored, freezing the session indefinitely.
What does this PR do?
Fixes #12133. Now fetches session info from SDK when the session is not found in the manager, allowing permission requests from child sessions to be properly forwarded to the ACP client.
How did you verify your code works?
I created a super simple ACP test client in Python that tests permission requests from Task subagents are properly forwarded to the ACP client (which auto-accepts the permission) by spawning 4 parallel OpenCode ACP processes (2 prod, 2 dev) with two prompts:
Baseline:
Test:
The prod-perm is EXPECTED to fail and time out (because the permissions never get forwarded, thus the ACP client just doesn't ever know it needs to do something)
test_acp.py