fix: propagate parent agent permissions to subagent child sessions - #12584
fix: propagate parent agent permissions to subagent child sessions#12584brittlewis12 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
When a primary agent with permissive rules (e.g. permission: 'allow') spawns a subagent via TaskTool, the parent agent's permission rules were not included in the child session's permission field. This caused subagents to use only their own restrictive defaults, meaning any tool call evaluating to 'ask' would block indefinitely in unattended mode. The fix resolves the calling agent and includes its permission rules in the child session, positioned before the hard-coded denies (todowrite, todoread, task) so findLast respects the override order correctly.
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found several related PRs that address subagent permission issues. Here are the potentially relevant ones (excluding the current PR #12584): Related PRs:
Important: Check if #12136 (handle permission requests from child sessions) might be addressing the same underlying issue as #12584, as both deal with child session permissions. |
Sorry, something went wrong.
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Sorry, something went wrong.
Fixes #12566
What does this PR do?
Subagents don’t respect the parent agent's permission rules, instead using their own restrictive defaults. Any tool call evaluating to 'ask' would block indefinitely, even when explicitly configured to run unattended.
This fix includes the parent agent’s permission rules in the child session, before the hard-coded denies (todowrite, todoread, task) so findLast respects the override order correctly.
How did you verify your code works?
wrote a regression test, saw it fail, and then made it pass.