fix(cli): handle SIGHUP to prevent orphaned processes on terminal close by shjeong92 · Pull Request #12718 · anomalyco/opencode · GitHub

What does this PR do?

When a terminal tab/window is closed, the OS sends SIGHUP to the process group. OpenCode has no SIGHUP handler, so the process ignores it and stays alive as an orphan under launchd (PPID=1), consuming memory indefinitely.

This adds SIGHUP and SIGTERM handlers to all long-running entry points:

index.ts: Safety net with 3s timeout fallback (covers all commands)
thread.ts: Graceful worker shutdown before exit (TUI mode)
worker.ts: Shutdown + ppid polling to detect parent death (safety net for SIGKILL)
attach.ts: Exit on signal (opencode attach mode)
serve.ts: Exit on signal (opencode serve mode)

The layered approach works like this: command-specific handlers do graceful cleanup and exit immediately, while the index.ts safety net force-exits after 3s if a command-specific handler hangs.

How did you verify your code works?

All 897 existing tests pass, 0 regressions
tsc --noEmit passes with no type errors
Added signal handling tests that spawn actual opencode serve, send SIGHUP/SIGTERM, and verify graceful exit (exit code 0 vs 129 without fix)
Manual test: start opencode, note PID, send kill -HUP <pid>, confirm process exits

The following comment was made by an LLM, it may be inaccurate:

Based on my search, here are the related PRs that might be duplicates or closely related:

Potentially Related PRs

fix: prevent orphaned worker process when killed #11603 - fix: prevent orphaned worker process when killed
- fix: prevent orphaned worker process when killed #11603
- Directly addresses orphaned worker processes, similar issue scope
fix: force kill MCP server processes on dispose to prevent orphan processes #7424 - fix: force kill MCP server processes on dispose to prevent orphan processes
- fix: force kill MCP server processes on dispose to prevent orphan processes #7424
- Handles orphaned process prevention through proper cleanup
fix(pty): use proper process tree cleanup on disposal #5876 - fix(pty): use proper process tree cleanup on disposal
- fix(pty): use proper process tree cleanup on disposal #5876
- Related to process cleanup and signal handling

Note: PR #12718 (the current PR) appears to be a comprehensive solution addressing the same orphaned process issue that previous PRs have attempted to fix. Check if #11603 and #7424 are closed/merged and whether this PR supersedes them or if there's overlapping work.

yeah I was just hit with this issue as well.

You have 68 opencode processes running, most dating back to Jan 28 - Feb 1. This happens when you close terminal windows without explicitly exiting opencode (Ctrl+C or /exit) - the processes keep running in the background.
These are consuming:

~10-15% total CPU (even while idle)
~8GB+ RAM combined
To clean them up, you can kill all except the current session:

Kill all opencode processes except the current one (PID 76275)

ps aux | grep opencode | grep -v grep | grep -v 76275 | awk '{print $2}' | xargs kill

Hmm I think that calling process.exit() explicitly skips some shutdown procedures which probably can cause corrupted writes (stdout/files etc)

Additionally it skips finally() blocks and other background work since it stops the event loop and exits synchronously.

Here is the Node docs which transfer to Bun as well: https://nodejs.org/api/process.html#processexitcode

@goniz Thanks for the feedback! You're right — I've updated the signal handlers to avoid calling process.exit() directly. They now remove their own listener and re-raise the signal so the default OS handler runs, allowing finally blocks and pending I/O to complete normally.

The only place process.exit() remains is in the index.ts safety net, which fires after a 3s timeout as a last resort if graceful shutdown hangs.

Check if you can use the process.once() instead of doing this dance.
If not, extract to a utility function and document the pattern

Good cal. switched all signal handlers to process.once() across the codebase (serve.ts, attach.ts, thread.ts, worker.ts, index.ts). No more manual off dance.

I think that this can lie due to race conditions. What if the parent dies and his pid gets recycled?

You can try checking if the processed moved to live under init as ppid / p group? Check me

You're right. the stale PID + kill(pid, 0) approach is vulnerable to PID recycling. Replaced it with a live process.ppid check each interval: when the worker gets reparented to init (ppid === 1), we know the parent is gone. Also gated behind process.platform !== "win32" since ppid semantics don't apply there.

…se (anomalyco#10563)

Tier 1 bug fixes: - Fix O(n²) bash output concatenation with StreamingOutput class (anomalyco#9693) - Fix memory leaks in Bus.once, Format, Plugin, ShareNext, Bootstrap (anomalyco#13514) - Fix FileTime race condition using actual file mtime instead of JS clock - Free memory on compaction prune: clear output/attachments/metadata (anomalyco#7049) - Throttle reasoning-delta storage writes to 50ms intervals (anomalyco#11328) - Handle SIGHUP/SIGTERM to prevent orphaned processes (anomalyco#12718) - Add process.once("close") handler for bash tool reliability Tier 2 features: - Support 1M context window for Anthropic models via beta header (anomalyco#14375) - Input-only token counting for compaction with limit.input models - MCP lazy loading: on-demand tool discovery via mcp_search tool (anomalyco#8771) - MCP servers listed in system prompt when lazy mode enabled - StreamingOutput: output_filter regex for build diagnostics - LSP server cleanup callback for temp directory removal - Extract formatSize utility from uninstall to shared util/format - GitHub CI: fix Bus subscription leak in session event handler Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR.

shjeong92 force-pushed the fix/handle-sighup-prevent-orphaned-processes branch from 4591da7 to ecdb049 Compare February 8, 2026 16:27

This was referenced Feb 9, 2026

fix(opencode): exit process on SIGHUP (#12767) #12865

Closed

fix: add signal handlers to prevent orphaned processes #12877

Closed

shjeong92 force-pushed the fix/handle-sighup-prevent-orphaned-processes branch 2 times, most recently from df894ca to f07b5c9 Compare February 15, 2026 00:50

goniz reviewed Feb 15, 2026

View reviewed changes

github-actions Bot mentioned this pull request Feb 16, 2026

fix(tui): add signal handlers to prevent orphaned processes on terminal close #13848

Closed

shjeong92 force-pushed the fix/handle-sighup-prevent-orphaned-processes branch 2 times, most recently from 7b5e903 to ebeb3df Compare February 17, 2026 07:37

github-actions Bot mentioned this pull request Feb 19, 2026

fix(opencode): run tui worker shutdown on signal/terminal-exit paths #14238

Closed

s2bomb mentioned this pull request Feb 19, 2026

TUI: signal exits leak child processes #14237

Closed

This was referenced Feb 20, 2026

fix: add SIGHUP/SIGTERM/SIGPIPE handlers to prevent orphaned processes #14505

Closed

fix: handle SIGHUP/SIGTERM/SIGPIPE to prevent orphaned processes #14548

Closed

fix(web): dispose idle MCP server instances to prevent process accumulation #15326

Closed

github-actions Bot mentioned this pull request Mar 1, 2026

fix(pty): pty session handle leak #15599

Merged

6 tasks

shjeong92 force-pushed the fix/handle-sighup-prevent-orphaned-processes branch from ebeb3df to c8d3c2e Compare March 3, 2026 01:33

fix(cli): handle SIGHUP to prevent orphaned processes on terminal clo…

eaf161c

…se (anomalyco#10563)

shjeong92 force-pushed the fix/handle-sighup-prevent-orphaned-processes branch from c8d3c2e to eaf161c Compare March 3, 2026 01:38

test(e2e): make session question seeding more resilient

89c11de

shjeong92 requested a review from adamdotdevin as a code owner March 3, 2026 02:03

github-actions Bot mentioned this pull request Mar 3, 2026

📊 AI CLI 工具社区动态日报 2026-03-03 rollysys/agents-radar#27

Closed

This was referenced Mar 21, 2026

Opencode now respects SIGTERMs and shuts down gracefully (K8 prehook … #18555

Closed

Opencode now respects SIGTERMs and shuts down gracefully (K8 prehook … #18556

Closed

This was referenced Apr 3, 2026

fix: use exit event instead of close to resolve bash tool hang with background processes #20901

Closed

fix(sdk): ensure opencode server closes cleanly via process groups #21626

Closed

opencode-agent Bot force-pushed the dev branch from 2f2ed11 to 9f201d6 Compare April 16, 2026 21:55

This was referenced Apr 25, 2026

fix(opencode): resolve heap unlimited + orphan processes on Linux #24297

Closed

fix(tui): handle SIGINT and SIGTERM for graceful shutdown #24659

Closed

github-actions Bot closed this May 2, 2026

+                  for (const signal of ["SIGHUP", "SIGTERM"] as const) {
+                    const handler = () => {
+                      process.off(signal, handler)
+                      process.kill(process.pid, signal)
+                    }
+                    process.on(signal, handler)
+                  }

+              if (ppid > 1) {
+                const monitor = setInterval(() => {
+                  try {
+                    process.kill(ppid, 0)

fix(cli): handle SIGHUP to prevent orphaned processes on terminal close by shjeong92 · Pull Request #12718 · anomalyco/opencode · GitHub

Uh oh!

fix(cli): handle SIGHUP to prevent orphaned processes on terminal close - #12718

fix(cli): handle SIGHUP to prevent orphaned processes on terminal close#12718
shjeong92 wants to merge 2 commits into
anomalyco:devfrom
shjeong92:fix/handle-sighup-prevent-orphaned-processes

shjeong92 commented Feb 8, 2026

Uh oh!

github-actions Bot commented Feb 8, 2026

Uh oh!

luisrudge commented Feb 8, 2026

Uh oh!

goniz commented Feb 11, 2026 •
edited
Loading

Uh oh!

Uh oh!

shjeong92 commented Feb 15, 2026

Uh oh!

goniz Feb 15, 2026

Uh oh!

shjeong92 Feb 17, 2026 •
edited
Loading

Uh oh!

Uh oh!

goniz Feb 15, 2026

Uh oh!

shjeong92 Feb 17, 2026 •
edited
Loading

Uh oh!

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(cli): handle SIGHUP to prevent orphaned processes on terminal close by shjeong92 · Pull Request #12718 · anomalyco/opencode · GitHub

Uh oh!

fix(cli): handle SIGHUP to prevent orphaned processes on terminal close - #12718

Conversation

shjeong92 commented Feb 8, 2026

What does this PR do?

How did you verify your code works?

Uh oh!

github-actions Bot commented Feb 8, 2026

Potentially Related PRs

Uh oh!

luisrudge commented Feb 8, 2026

Kill all opencode processes except the current one (PID 76275)

Uh oh!

goniz commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shjeong92 commented Feb 15, 2026

Uh oh!

goniz Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

shjeong92 Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goniz Feb 15, 2026

Choose a reason for hiding this comment

Uh oh!

shjeong92 Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

goniz commented Feb 11, 2026 •
edited
Loading

shjeong92 Feb 17, 2026 •
edited
Loading

shjeong92 Feb 17, 2026 •
edited
Loading