fix: handle SIGHUP/SIGTERM/SIGPIPE to prevent orphaned processes - #14548
Closed
kevinWangSheng wants to merge 1 commit into
Closed
fix: handle SIGHUP/SIGTERM/SIGPIPE to prevent orphaned processes#14548kevinWangSheng wants to merge 1 commit into
kevinWangSheng wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
When a controlling terminal is destroyed (SSH disconnect, tmux pane close), opencode processes become orphaned and continue running indefinitely because no signal handler triggers process.exit(). Add handlers for SIGHUP, SIGTERM, and SIGPIPE so the existing subprocess cleanup in the finally block runs promptly. Fixes anomalyco#14504 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #14504
Type of change
What does this PR do?
Adds signal handlers for SIGHUP, SIGTERM, and SIGPIPE that call process.exit(1). Without these, when a terminal dies (SSH disconnect, tmux pane close), opencode processes become orphaned because cli.parse() never resolves and process.exit() in the finally block never runs. Each orphan leaks ~4.7 GB of RAM.
How did you verify your code works?
Reviewed the 3-line change. process.on(sig, () => process.exit(1)) triggers the existing finally-block cleanup. All CI checks pass.
Screenshots / recordings
N/A - no UI change.
Checklist