FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(tui): graceful exit on Ctrl+C and resolve multiline paste corruption by n24q02m · Pull Request #14440 · anomalyco/opencode · GitHub

/ opencode Public

fix(tui): graceful exit on Ctrl+C and resolve multiline paste corruption - #14440

Closed
n24q02m wants to merge 2 commits into
anomalyco:devfrom
n24q02m:fix/tui-bugs
ConversationCommits (2)ChecksFiles changed
Closed

fix(tui): graceful exit on Ctrl+C and resolve multiline paste corruption#14440
n24q02m wants to merge 2 commits into
anomalyco:devfrom
n24q02m:fix/tui-bugs

Conversation

n24q02m commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Closes #11826
Closes #10975
Closes #12767

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

  1. Graceful Exit: Resolves the zombie process issue when closing the TUI. By adding a SIGHUP handler in src/index.ts and a fallback process.exit(0) after standard renderer and event loop cleanup, the application will forcefully exit if background processes (like file watchers or MCP servers) are blocking a clean exit.
  2. Double Ctrl+C: Instead of exiting immediately upon hitting Ctrl+C on an empty prompt (which was frustrating), users now receive a warning toast first. Pressing it again within 2 seconds confirms the exit.
  3. Multiline Paste: Fixes UI corruption and data loss that occurred when pasting large text. Previously, the system generated an extmark [Pasted ~X lines] but didn't actually insert the text into the internal buffer. Now, the raw text is directly inserted via input.insertText().

How did you verify your code works?

Pasted >150 lines of text successfully without UI corruption. Pressed Ctrl+C twice and confirmed the terminal exits immediately. Ran kill -HUP on the process and verified that all child LSP processes were also cleaned up instead of being orphaned.

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Feb 20, 2026

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one potentially related PR:

#13848 - fix(tui): add signal handlers to prevent orphaned processes on terminal close

This PR appears to address a similar issue with graceful process cleanup and preventing orphaned/zombie processes on terminal close. It may overlap with the Ctrl+C graceful exit handling in PR #14440.

All other search results either returned PR #14440 itself or addressed different concerns (MCP server processes, ANSI color codes, memory leaks, etc.).

github-actions Bot removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Feb 20, 2026

github-actions Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

github-actions Bot mentioned this pull request Feb 21, 2026
Closed
6 tasks
n24q02m force-pushed the fix/tui-bugs branch 2 times, most recently from 39dea04 to cd017db Compare February 25, 2026 01:52

n24q02m commented Mar 6, 2026

Copy link
Copy Markdown
Author

Closing this PR -- it has merge conflicts, 2 CI failures (e2e windows + test linux), and a similar PR #13848 was already closed without merge. The effort to fix and rebase is not justified given these signals. The underlying issues (#11826, #10975, #12767) remain open for others to tackle with a fresh approach.

n24q02m closed this Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

1 participant

Back | FazBrowse Home | New Git URL