fix: render permission and question prompts from nested subagent session - #13719
fix: render permission and question prompts from nested subagent session#13719ro-hansolo wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
The following comment was made by an LLM, it may be inaccurate: I found a potentially related PR: PR #10539: fix(questions): fixes #7654 where sub-sub agents can't ask questions This PR may be related because it also addresses an issue with nested subagents (sub-sub agents) not being able to ask questions. Your PR #13719 fixes a similar problem where permission and question prompts from nested subagent sessions were silently hanging. Both involve rendering prompts from deeper levels in the session hierarchy. However, this appears to be a historical PR that may have already been merged. The current PR (#13719) likely addresses a regression or a similar issue with a different implementation approach. |
Sorry, something went wrong.
|
This PR solves a big problem I've been experiencing because I have most permissions set to ask. Any chance of getting it merged? Thanks |
Sorry, something went wrong.
|
Hi @thdxr, could you please take a look at this PR when you get a chance? Thank you for all your hard work and contributions to the project! |
Sorry, something went wrong.
|
Hi, @rekram1-node, wondering if there's any chance this patch can be merged soon, thanks! |
Sorry, something went wrong.
|
Thanks for the prior work here. I opened a follow-up PR with the same bug target plus focused regression tests: I compiled and tested this locally, and I can confirm the fix resolves the issue in live usage. It would be great to land this upstream so I don’t have to maintain a fork just to keep receiving updates. Thank you all for the great work maintaining OpenCode — really appreciate it. |
Sorry, something went wrong.
What does this PR do?
Fixes #13715
Permission and question prompts from nested subagent sessions (grandchild+) silently hang. The children() memo in session/index.tsx only collects direct child sessions, so events from deeper sessions are never rendered in the TUI.
Added a descendants() memo that walks the full session tree using Set iteration. Permissions and questions now use descendants() while tab navigation still uses the original children().
How did you verify your code works?
Spawned a general subagent that spawns another general subagent requiring bash permission. Before: TUI hangs silently. After: permission prompt surfaces. Video attached.
Before:
Screen.Recording.2026-02-15.at.3.58.30.PM.movAfter:
Bug.Fix.mov