fix(tui): show permission prompts from nested subagent chains by NaturalSelect · Pull Request #36046 · anomalyco/opencode · GitHub

Issue for this PR

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

Nested subagents (a subagent spawning its own subagent) could trigger a permission request that was never rendered in the UI, deadlocking the whole call chain. The TUI and CLI only tracked direct child sessions, so grandchild session events were silently dropped and the user had no way to approve the pending permission.

Root cause: both the TUI's permission collection and the CLI's subagent footer only looked one level deep in the session tree (direct children), instead of the full subtree. The permission events themselves were delivered correctly (SSE broadcast is not session-scoped) — the gap was purely in how the UI/CLI decided which sessions to display.

Changes:

packages/tui/src/routes/session/index.tsx: collect the full session subtree (not just direct children) when gathering pending permissions/questions. Added a collectSubtree helper and a subtree() memo; the existing children() memo is left untouched since it's still used for tab navigation, which should stay direct-children-only.
packages/opencode/src/cli/cmd/run/stream.transport.ts: bootstrap the CLI subagent footer with all descendants via a level-by-level BFS (collectDescendantSessions) instead of a single session.children() call, so a reconnect/cold start picks up grandchild sessions too.
packages/opencode/src/cli/cmd/run/subagent-data.ts: in reduceSubagentData, register a grandchild tab when a known child session spawns a nested task, without skipping the child's own event tracking (previously the function returned early only for the root session's own task events).
packages/app/src/context/permission-auto-respond.test.ts: added regression coverage for a three-level session chain. The auto-accept lookup already walks the full parent chain (sessionLineage), so no code change was needed there — just locking in the behavior with a test.

How did you verify your code works?

bun run typecheck passes in packages/opencode, packages/tui, and packages/app.
Added unit tests: collectSubtree (single/three-level chains, sibling isolation, cycle guard), a bootstrap test asserting grandchild tabs/permissions surface after a level-by-level BFS, a live-event test asserting a grandchild tab is registered when a known child spawns a nested task, and three grandchild-lineage cases for autoRespondsPermission.
Ran the targeted suites (stream.transport.test.ts, subagent-data.test.ts, permission-auto-respond.test.ts) plus the new test file — all passing, no regressions in existing cases.

Screenshots / recordings

N/A — this fixes visibility of an existing permission prompt for deeper session nesting; no new UI surface.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

The following comment was made by an LLM, it may be inaccurate:

Potential Related PRs Found

Note: These are related to the same problem space (nested subagent permission prompts), but most appear to be older attempts or adjacent features. Current PR #36046 seems to be a new fix for this recurring issue.

fix(acp): surface subagent sessions and route child permissions #33293 - fix(acp): surface subagent sessions and route child permissions
- Related: Addresses routing permissions from child sessions to UI
fix(session): route nested blockers to ancestor clients #30639 - fix(session): route nested subagent permission prompts to ancestor UI
- Most Similar: Directly tackles the same problem of routing nested permission prompts
fix(tui): propagate permissions from nested subagents and show full subtask tree #24638 - fix(tui): propagate permissions from nested subagents and show full subtask tree
- Related: Previous attempt to show permissions from nested subagents and display full subtree
feat: nested sub-agent spawning (up to 5 levels) + fixes for #23091 / #13715 #32301 - feat: nested sub-agent spawning (up to 5 levels) + fixes for #23091 / #13715
- Related: Nested subagent spawning feature and related fixes
fix: render permission and question prompts from nested subagent session #13719 - fix: render permission and question prompts from nested subagent session
- Related: Similar problem from an earlier version
feat(opencode): add Dynamic workflows (new Claude Code feature) #29789 - feat(opencode): add Dynamic workflows (new Claude Code feature)
- May be related to subagent functionality

The current PR (#36046) appears to be addressing a recurring issue with nested subagent permission visibility. #30639 and #24638 are the most directly related, as they target the same root cause. You may want to verify if this is a re-fix of a previously closed issue or if those older PRs had different approaches.

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Ported from upstream anomalyco#36046.

@Hona @Brendonovich Hi, PTAL~

Nested subagents (subagent spawning a subagent) could trigger a permission request that was never rendered in the UI, deadlocking the whole call chain. The TUI and CLI only tracked direct child sessions, so grandchild session events were silently dropped. - tui: collect the full session subtree (not just direct children) when gathering pending permissions/questions - opencode: bootstrap the CLI subagent footer with all descendants via a level-by-level BFS instead of only direct children - opencode: register grandchild tabs when a known child session spawns a nested task, without skipping the child's own event tracking - app: add regression coverage confirming auto-accept rules already propagate correctly across a three-level session chain Signed-off-by: huangzhibin1 <huangzhibin1@xiaomi.com>

I reviewed this alongside the other implementations linked from #13715.

This PR is the closest current implementation of the model already used by the web/desktop app: preserve the nested request’s actual session and make the TUI/headless clients aware of the complete session subtree.

I added a coordination comment to #13715 asking maintainers to clarify whether this is the intended long-term architecture, or whether core should instead expose a separate root/presentation owner for nested blockers.

My preference is:

keep sessionID as the actual leaf session that requested permission;
add a separate core-computed presentation/owner session ID;
have clients select blockers through that field rather than independently reconstructing the tree.

The TUI traversal in this PR remains a valid and low-risk fix for the current deadlock. The architectural question is whether the same traversal should continue to be duplicated across clients or move behind a shared core contract.

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

The PR was created more than 1 month ago
The PR had fewer than 2 positive reactions
Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

41496

NaturalSelect requested review from Brendonovich and Hona as code owners July 9, 2026 08:00

NaturalSelect force-pushed the fix_subagent_perm branch from c57f380 to 0be4411 Compare July 9, 2026 08:00

github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jul 9, 2026

github-actions Bot removed needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels Jul 9, 2026

CreatorGhost mentioned this pull request Jul 11, 2026

fix(tui): show permission prompts from nested subagent chains CreatorGhost/TheCode#21

Merged

CreatorGhost added a commit to CreatorGhost/TheCode that referenced this pull request Jul 12, 2026

fix(tui): show permission prompts from nested subagent chains

3db6ba6

Ported from upstream anomalyco#36046.

CreatorGhost added a commit to CreatorGhost/TheCode that referenced this pull request Jul 12, 2026

fix(tui): show permission prompts from nested subagent chains (#21 )

b834fdc

Ported from upstream anomalyco#36046.

github-actions Bot mentioned this pull request Jul 14, 2026

fix(cli): handle descendant permission asks #36898

Closed

6 tasks

flowluap mentioned this pull request Jul 20, 2026

refactor(opencode): suppress hidden subagent updates #37899

Closed

6 tasks

NaturalSelect force-pushed the fix_subagent_perm branch from 0be4411 to ef72394 Compare July 22, 2026 04:10

NaturalSelect force-pushed the fix_subagent_perm branch from ef72394 to 85693bc Compare July 26, 2026 09:21

samiralibabic mentioned this pull request Aug 3, 2026

Permission asks from nested subagent sessions silently hang #13715

Open

github-actions Bot closed this Aug 9, 2026

github-actions Bot added the automated-pr-cleanup label Aug 9, 2026

NaturalSelect mentioned this pull request Aug 10, 2026

fix(tui): show permission prompts from nested subagent chains #41496

Open

6 tasks

fix(tui): show permission prompts from nested subagent chains by NaturalSelect · Pull Request #36046 · anomalyco/opencode · GitHub

Uh oh!

fix(tui): show permission prompts from nested subagent chains - #36046

fix(tui): show permission prompts from nested subagent chains#36046
NaturalSelect wants to merge 1 commit into
anomalyco:devfrom
NaturalSelect:fix_subagent_perm

NaturalSelect commented Jul 9, 2026 •
edited
Loading

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

NaturalSelect commented Jul 22, 2026

Uh oh!

samiralibabic commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

NaturalSelect commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(tui): show permission prompts from nested subagent chains by NaturalSelect · Pull Request #36046 · anomalyco/opencode · GitHub

Uh oh!

fix(tui): show permission prompts from nested subagent chains - #36046

fix(tui): show permission prompts from nested subagent chains#36046NaturalSelect wants to merge 1 commit intoanomalyco:devanomalyco/opencode:devfrom NaturalSelect:fix_subagent_permNaturalSelect/opencode:fix_subagent_permCopy head branch name to clipboard

Conversation

NaturalSelect commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Potential Related PRs Found

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

NaturalSelect commented Jul 22, 2026

Uh oh!

samiralibabic commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 9, 2026

Uh oh!

NaturalSelect commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(tui): show permission prompts from nested subagent chains#36046
NaturalSelect wants to merge 1 commit into
anomalyco:devfrom
NaturalSelect:fix_subagent_perm

NaturalSelect commented Jul 9, 2026 •
edited
Loading