fix(acp): surface subagent sessions and route child permissions - #33293
fix(acp): surface subagent sessions and route child permissions#33293WaterRRabbit wants to merge 1 commit into
Conversation
Sorry, something went wrong.
Register task child sessions in the ACP session store, resolve unknown sessions via SDK ancestry, forward child stream/tool updates, and route permission prompts to the root session with childSessionId context. Closes anomalyco#32388 Co-authored-by: Cursor <cursoragent@cursor.com>
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Related PR:
You should check PR #32445 first, as it has an identical title to the current PR and is likely a duplicate or prior attempt at the same fix. |
Sorry, something went wrong.
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Sorry, something went wrong.
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Sorry, something went wrong.
Issue for this PR
Closes #32388
Type of change
What does this PR do?
When a task tool spawns a subagent, the child session ID was not registered in the ACP session store. The ACP event subscription only looked up sessions it already knew about, so child stream/tool updates were dropped and permission prompts from child sessions never reached the client — the session appeared hung.
This PR adds a SessionResolver that walks the SDK parent chain to register unknown child sessions against their root ACP session. Child tool/stream events are forwarded through the resolved parent, and permission prompts are routed to the root session with childSessionId in rawInput so the client can attribute them correctly.
This is a clean re-submission of the same fix from #32445, without the unrelated CI/release workflow commits from that branch.
How did you verify your code works?
Ran the ACP unit tests added/updated in this PR:
All 13 tests in those files pass. Coverage includes: SDK ancestry resolution, nested grandchild registration, cycle detection, session deletion invalidation, child event forwarding, and permission routing to root with childSessionId.
Screenshots / recordings
No UI change — ACP protocol layer only.
Checklist