FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: subagent permissions bypass and Lost restrictions after compaction by nightguarder · Pull Request #21661 · anomalyco/opencode · GitHub

/ opencode Public

fix: subagent permissions bypass and Lost restrictions after compaction - #21661

Closed
nightguarder wants to merge 5 commits into
anomalyco:devfrom
nightguarder:fix/6527-subagent-permissions
ConversationCommits (5)ChecksFiles changed
Closed

fix: subagent permissions bypass and Lost restrictions after compaction#21661
nightguarder wants to merge 5 commits into
anomalyco:devfrom
nightguarder:fix/6527-subagent-permissions

Conversation

nightguarder commented Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Issue for this PR

Plan mode restrictions bypassed when spawning sub-agents

Fixes #18213: Readonly restrictions lost after compaction

Fixes #6527: Sub-agent permission bypass in Plan mode

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Fixes sub-agent permission bypass: when spawning sub-agents from Plan mode, they now inherit the parent session's permissions (including edit: deny). Previously, sub-agents ran with full permissions and could edit files despite Plan mode being active.

task.ts - Gets caller agent permissions, merges with session, adds edit: deny if parent has it, updates persisted session permission (including resumed task_id sessions)
prompt.ts - Merges tool-derived permissions with existing session rules instead of replacing them
bash.ts - Detects output redirection (>, >>) and sed -i and requires edit permission for them

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

I ran bun dev and verified the project builds and start

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Hey! Your PR title Fix: subagent permissions bypass and Lost restrictions after compaction doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found

PR #18764: fix(opencode): preserve readonly subagent restrictions across compaction

Reason: This PR directly addresses the same issue (#18213) mentioned in the current PR - preserving readonly restrictions after compaction. Both PRs are tackling permission preservation for subagents during compaction operations, which appears to be overlapping scope.

nightguarder changed the title Fix: subagent permissions bypass and Lost restrictions after compaction fix: subagent permissions bypass and Lost restrictions after compaction Apr 9, 2026

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

This was referenced Apr 18, 2026
Merged
Closed
github-actions Bot mentioned this pull request May 15, 2026
Closed
3 tasks

rekram1-node commented May 15, 2026

Copy link
Copy Markdown
Collaborator

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sub-agent in plan mode bypasses restrictions after compaction [CRITICAL Security Issue/Bug] Plan mode restrictions bypassed when spawning sub-agents

2 participants

Back | FazBrowse Home | New Git URL