fix(task): subagent explicit edit:allow overrides parent edit:deny by OrShmuel22 · Pull Request #27654 · anomalyco/opencode · GitHub

Issue for this PR

Type of change

Bug fix

What does this PR do?

deriveSubagentSessionPermission unconditionally inherits the parent agent's edit: deny rules into the subagent's session. Because permission evaluation is last-match-wins, the inherited deny overrides the subagent's own edit: allow. The subagent loses the edit tool entirely.

This breaks any setup where a restricted parent (like an orchestrator with edit: deny) deliberately delegates to a capable subagent (like an editor with edit: allow).

The fix: only inherit the parent's edit: deny when the subagent does NOT explicitly declare edit: allow. If a subagent says it can edit, the parent's self-restriction shouldn't override that. If the subagent has no edit rule, the parent's deny still applies as a ceiling.

This works because the permission system is all about ordering — rules that appear last in the merged array win. By not injecting the parent's deny into the session when the subagent explicitly allows edit, the subagent's own allow rule is the last match and wins. The core evaluate(), merge(), and disabled() functions are not touched.

How did you verify your code works?

Added 3 new tests in plan-mode-subagent-bypass.test.ts:

subagent with explicit edit: allow overrides parent edit: deny
subagent without explicit edit inherits parent edit: deny
orchestrator pattern: parent edit: deny does not override subagent edit: allow

All existing Plan Mode security tests still pass because general and explore don't have explicit edit: allow — so they still inherit the plan agent's deny.

Full test run: 114 tests pass (8 subagent-bypass + 85 permission + 21 permission-task).

Screenshots / recordings

N/A — no UI changes.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found:

PR fix(task): only inherit edit-class denies from parent agent to subagent #26845: "fix(task): only inherit edit-class denies from parent agent to subagent"
- fix(task): only inherit edit-class denies from parent agent to subagent #26845
- Why it's related: This PR addresses the exact same issue — how edit denies are inherited from parent agents to subagents. It appears to be a closely related or potentially overlapping fix to the same problem in subagent-permissions.ts.

Other Related PRs:

PR fix(task): propagate parent session permissions to sub-agents #24293: "fix(task): propagate parent session permissions to sub-agents" — Related to parent/subagent permission inheritance
PR fix: subagent permissions bypass and Lost restrictions after compaction #21661: "fix: subagent permissions bypass and Lost restrictions after compaction" — Related to subagent permission handling

Recommend checking PR #26845 first as it directly addresses the parent edit deny inheritance issue.

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Quick context on how this differs from the other PRs people might find:

fix(task): preserve subagent self permissions #27201 (merged) — narrowed inheritance from ALL parent denies to only edit-class denies. Fixed bash/read/task inheritance. But parent edit: deny still overrides subagent edit: allow.
fix(task): only inherit edit-class denies from parent agent to subagent #26845 (open) — proposes the same narrowing as fix(task): preserve subagent self permissions #27201. Would have the same gap.
This PR — adds the missing piece: if a subagent explicitly declares edit: allow, the parent's edit: deny is not inherited. Subagents without explicit edit declaration still inherit the deny (Plan Mode stays secure).

@kitlangton — this builds on your #27201 fix. That PR fixed most of the regression, but orchestrator→editor patterns where the parent has edit: deny and the subagent has edit: allow are still broken. This PR adds the subagent self-declaration check on top.

This PR only applies fix for "*": allow, but adding allow to specific file paths/globs is still not possible, e.g. like in

fix(task): preserve subagent self permissions #27201 (comment)

But the fix is rather trivial, just removing the explicit *

Good catch @Sewer56, fixed — any edit: allow rule (scoped or wildcard) now prevents parent edit:deny inheritance, not just pattern === "*". Added a test for scoped patterns too.

@kitlangton Ready for review.

@thdxr would be really awesome to get this one sometime soon

@kitlangton @jlongster @Brendonovich @rekram1-node — this PR has been open for 6 days with no review. It is the final missing piece of the subagent permission inheritance fix chain.

The progression:

fix(task): subagent inherits parent agent's deny rules (Plan Mode security bypass) #26597 (merged) — closed Plan Mode bypass, but over-inherited ALL parent denies
fix(task): preserve subagent self permissions #27201 (merged by @kitlangton) — narrowed to edit-class only, but parent edit:deny still overrides subagent edit:allow
fix(task): subagent explicit edit:allow overrides parent edit:deny #27654 ← this PR — adds the subagent self-declaration check so explicit edit:allow wins over inherited deny

Without this, orchestrator→editor and commander→worker patterns remain broken for every multi-agent setup. The fix is small (one conditional in subagent-permissions.ts), preserves Plan Mode security, and all 114 tests pass.

Community members blocked by this: @nabilfreeman @BurnySc2 @ROKO108 @nmzpy @Sewer56 @tppawelgrzesik

Ready to merge — please review.

🎻

Well I guess we can try to get some more attention here, this one is blocking many of us from updating to newer versions of opencode for quite a while now.

@adamdotdevin @Hona @Brendonovich pretty please guys, lets fix it 💯

When a parent agent (e.g. an orchestrator) has edit:deny and spawns a subagent (e.g. an editor) that has edit:allow, the parent's deny was unconditionally inherited into the subagent's session permission. Because permission evaluation is last-match-wins, the inherited deny overrode the subagent's own allow — removing the edit tool from the subagent's palette. Fix: only inherit parent edit:deny rules when the subagent does NOT explicitly declare edit:allow. If a subagent says it can edit, the parent's self-restriction should not override that declared capability. This preserves Plan Mode security: subagents without explicit edit declarations (like general, explore) still inherit the parent's edit:deny as before. Relates to anomalyco#26700 anomalyco#26747 anomalyco#26758 anomalyco#27123

…d parent denies deriveSubagentSessionPermission no longer forwards a parent agent's edit deny (or parent-session denies) for any permission the subagent explicitly allows, so custom subagents like general-opus-4.7 (edit: allow) spawned by edit-denying orchestrators keep edit/write access. Built-in explore/general still inherit the Plan Mode ceiling since they don't declare edit: allow. Adds regression tests and documents the recurring regression + invariant in AGENTS.md. Refs anomalyco#26514 anomalyco#27201 anomalyco#27654.

I just run my own OpenCode fork; since it's the easiest way to proceed in a case like this.

Well it seems that on this project it's impossible to escalate a PR to get critical fixes merged quick.
All the maintainers seem to never respond in PRs, even if they are quoted.
Sad story.

For example opencode-mem plugin is completely broken for a long time too.
It's a bug in opencode and a PR also exists for a long time.

Meanwhile releases get pushed sometimes "hourly" because of bugs and bad quality.
And include some random new features that do not contribute to getting opencode a more stable and bug-free experience at all.

Imo. what this project really needs is a "new-feature-freeze", a phase that focuses on getting more stability and a less bugged experience.

This behavior is intentional

This behavior is intentional

Why?

This behavior is intentional

@rekram1-node my use-case:

Orchestrator primary agent has edit: deny and has task permission allow for "Developer" subagent
Orchestrator starts a subagent, eg Developer
Developer has edit: allow

With current version of opencode Developer cannot use edit/write tool because he inherits Orchestrator deny.
eg. His own edit permission does not overwrite the permission from Orchestrator.

Now I could set Orchestrator to edit: allow, however now I risk that if he forgets his primary instruction to not edit/write files on his own, he WILL start doing it by mistake.

Also a side note if i recall correctly, other use-cases:
Orchestrator -> Lead dev -> dev
edit deny -> edit allow -> edit allow

Here dev can use write/edit tool. Because the bug seems to only affect forced permission from direct parent only.

Because lead dev has in leadDev.md edit permission: allow
dev can now edit/write files as the bug is not triggering in this use-case.

Another use-case:
Orchestrator -> LeadDev -> Dev
edit: allow -> edit: deny -> edit allow

Here dev cannot use write/edit tool either.

I don't understand how this can be intentional.
You have the "Task" permission to allow or not allow using a subagent.
This subagent has his own permissions, respect them.

Heads up — I've forked opencode to a stable branch and I'm maintaining it separately for now.

What I fixed (all things upstream doesn't currently have):

This PR: subagent edit:allow overriding parent edit:deny
Scoped edit:allow override (same bug, globs)
Network disconnect retries, capped at 3
retry_exhausted status so sessions don't hang when retries die
Double-submit prevention + server-side dismiss
Busy-flip revert on prompt failure
Stalled-stream retry after sleep/wake
SSE reconnect re-syncs session status
Provider timeout + wake-watch infra

Not chasing upstream. No new features. Only important, high-impact fixes — and only once they're stable. If a new upstream feature fits and we need it, I'll add it.

@tppawelgrzesik @Sewer56 — fork is here if useful: https://github.com/OrShmuel22/opencode

@rekram1-node the delegation pattern (orchestrator edit:deny → editor edit:allow) is in your own agent docs. If it's "intentional," the docs need updating.

I can just guess that in the end nobody will care but yeah the way this project currently runs seems sadly fundamentally broken.

Nonetheless, thanks everyone, including the community for trying to make things better and all the contributions.

@thdxr @adamdotdevin @kitlangton @iamdavidhill @fwang @jayair @Brendonovich @nexxeln @Hona @kommander @jlongster

github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels May 15, 2026

github-actions Bot removed needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels May 15, 2026

github-actions Bot mentioned this pull request May 25, 2026

fix(task): respect subagent explicit edit:allow over inherited parent edit:deny #29235

Closed

3 tasks

This was referenced May 28, 2026

fix(subagent): inherit parent session allow rules for MCP tool permissions #29718

Closed

fix(opencode): granular subagent edit permission inheritance #29778

Closed

OrShmuel22 force-pushed the fix/subagent-edit-permission-override branch from 2b7ea40 to d25e870 Compare May 30, 2026 07:58

OrShmuel22 added 2 commits May 30, 2026 11:05

fix(task): scoped edit:allow also overrides parent edit:deny

a439448

OrShmuel22 force-pushed the fix/subagent-edit-permission-override branch from d25e870 to a439448 Compare May 30, 2026 08:12

github-actions Bot mentioned this pull request Jun 5, 2026

docs(plan): サブエージェントの権限マージの修正計画を作成 #30845

Closed

6 tasks

OrShmuel22 closed this Jun 18, 2026

OrShmuel22 deleted the fix/subagent-edit-permission-override branch June 18, 2026 16:04

fix(task): subagent explicit edit:allow overrides parent edit:deny by OrShmuel22 · Pull Request #27654 · anomalyco/opencode · GitHub

Uh oh!

fix(task): subagent explicit edit:allow overrides parent edit:deny - #27654

fix(task): subagent explicit edit:allow overrides parent edit:deny#27654OrShmuel22 wants to merge 2 commits intoanomalyco:devanomalyco/opencode:devfrom OrShmuel22:fix/subagent-edit-permission-overrideOrShmuel22/opencode:fix/subagent-edit-permission-overrideCopy head branch name to clipboard

Conversation

OrShmuel22 commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

github-actions Bot commented May 15, 2026

Uh oh!

OrShmuel22 commented May 15, 2026

Uh oh!

Sewer56 commented May 17, 2026

Uh oh!

OrShmuel22 commented May 17, 2026

Uh oh!

OrShmuel22 commented May 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tppawelgrzesik commented May 18, 2026

Uh oh!

OrShmuel22 commented May 21, 2026

Uh oh!

Sewer56 commented May 21, 2026

Uh oh!

tppawelgrzesik commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sewer56 commented Jun 13, 2026

Uh oh!

tppawelgrzesik commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rekram1-node commented Jun 18, 2026

Uh oh!

OrShmuel22 commented Jun 18, 2026

Uh oh!

tppawelgrzesik commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OrShmuel22 commented Jun 18, 2026

@rekram1-node the delegation pattern (orchestrator edit:deny → editor edit:allow) is in your own agent docs. If it's "intentional," the docs need updating.

Uh oh!

tppawelgrzesik commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(task): subagent explicit edit:allow overrides parent edit:deny#27654
OrShmuel22 wants to merge 2 commits into
anomalyco:devfrom
OrShmuel22:fix/subagent-edit-permission-override

OrShmuel22 commented May 15, 2026 •
edited
Loading

OrShmuel22 commented May 17, 2026 •
edited
Loading

tppawelgrzesik commented May 27, 2026 •
edited
Loading

tppawelgrzesik commented Jun 18, 2026 •
edited
Loading

tppawelgrzesik commented Jun 18, 2026 •
edited
Loading

tppawelgrzesik commented Jun 19, 2026 •
edited
Loading