fix: allow fork with explicit directory for stale sessions - #49987
Open
MartinSchlott wants to merge 1 commit into
Open
MartinSchlott wants to merge 1 commit into
MartinSchlott wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #46276
Type of change
What does this PR do?
Session requests normally remain pinned to their stored directory. This made it impossible to fork a session whose directory had moved or disappeared, even when the caller explicitly supplied a valid directory.
This change allows only POST /session/:id/fork to prefer an explicitly requested directory. Other session requests keep the existing behavior.
How did you verify your code works?
Added a regression test covering a missing parent directory, the explicit fork directory, and copied message history.
Also verified the full CLI flow with separate processes and persistent storage: create a parent session, move its directory, then run with --session, --fork, and --dir.
Screenshots / recordings
Not applicable.
Checklist