FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: allow fork with explicit directory for stale sessions by MartinSchlott · Pull Request #49987 · anomalyco/opencode · GitHub

Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .ts  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@ function planRequest(
): Effect.Effect<RequestPlan, never, Workspace.Service> {
return Effect.gen(function* () {
const url = requestURL(request)
const forkDirectory =
request.method === "POST" && /^\/session\/[^/]+\/fork$/.test(url.pathname)
? url.searchParams.get("directory") || request.headers["x-opencode-directory"]
: undefined
const envWorkspaceID = configuredWorkspaceID()
const workspaceID = url.pathname.startsWith("/api/")
? selectedV2WorkspaceID(url, session?.workspaceID)
Expand All @@ -179,7 +183,7 @@ function planRequest(
}

return RequestPlan.Local({
directory: session?.directory || defaultDirectory(request, url),
directory: forkDirectory || session?.directory || defaultDirectory(request, url),
workspaceID: envWorkspaceID ?? workspaceID,
})
})
Expand Down
58 changes: 57 additions & 1 deletion packages/opencode/test/server/httpapi-session.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { PermissionV1 } from "@opencode-ai/core/v1/permission"
import { createOpencodeClient } from "@opencode-ai/sdk/v2"
import { afterEach, describe, expect } from "bun:test"
import { NodeHttpServer, NodeServices } from "@effect/platform-node"
import { SessionV1 } from "@opencode-ai/core/v1/session"
Expand Down Expand Up @@ -207,6 +208,17 @@ const clearSessionPath = (sessionID: SessionIDType) =>
yield* db.update(SessionTable).set({ path: null }).where(eq(SessionTable.id, sessionID)).run().pipe(Effect.orDie)
})

const setSessionDirectory = (sessionID: SessionIDType, directory: string) =>
Effect.gen(function* () {
const database = yield* Database.Service
yield* database.db
.update(SessionTable)
.set({ directory })
.where(eq(SessionTable.id, sessionID))
.run()
.pipe(Effect.orDie)
})

function request(path: string, init?: RequestInit) {
const url = new URL(path, "http://localhost")
return HttpClientRequest.fromWeb(new Request(url, init)).pipe(
Expand Down Expand Up @@ -388,7 +400,7 @@ describe("session HttpApi", () => {
{ git: true, config: { formatter: false, lsp: false } },
)

it.live("uses the persisted session directory for prompt requests", () =>
it.live("does not override the persisted session directory for non-fork requests", () =>
Effect.gen(function* () {
const llm = yield* TestLLMServer
yield* llm.text("ok", { usage: { input: 1, output: 1 } })
Expand Down Expand Up @@ -427,6 +439,50 @@ describe("session HttpApi", () => {
}).pipe(Effect.provide(TestLLMServer.layer), Effect.provide(AppNodeBuilder.build(CrossSpawnSpawner.node))),
)

it.live("forks a session with a stale directory into an explicit directory", () =>
Effect.gen(function* () {
const parentDirectory = yield* tmpdirScoped({ git: true })
const targetDirectory = yield* tmpdirScoped({ git: true })
const parent = yield* createSession({ title: "stale directory parent" }).pipe(
provideInstanceEffect(parentDirectory),
)
const message = yield* createTextMessage(parent.id, "preserve this history").pipe(
provideInstanceEffect(parentDirectory),
)
yield* setSessionDirectory(parent.id, path.join(parentDirectory, "missing"))

const sdk = yield* HttpServer.HttpServer.use((server) =>
Effect.succeed(
createOpencodeClient({
baseUrl: HttpServer.formatAddress(server.address),
directory: targetDirectory,
}),
),
)
const current = yield* Effect.promise(() => sdk.session.get({ sessionID: parent.id }))
expect(current.data?.id).toBe(parent.id)

const forked = yield* Effect.promise(() => sdk.session.fork({ sessionID: parent.id }))
expect(forked.response.status).toBe(200)
if (!forked.data) return yield* Effect.die("Fork response did not include a session")
const child = forked.data
expect(child.directory).toBe(targetDirectory)

const childID = SessionID.make(child.id)
const messages = yield* Session.use
.messages({ sessionID: childID })
.pipe(provideInstanceEffect(targetDirectory), Effect.orDie)
expect(messages).toHaveLength(1)
expect(messages[0]?.parts).toEqual([
expect.objectContaining({
type: "text",
text: message.part.text,
sessionID: childID,
}),
])
}),
)

it.instance(
"returns v2 public request errors for cursor and workspace query failures",
() =>
Expand Down
Loading

Back | FazBrowse Home | New Git URL