FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GH-10: Add basic pre-commit-config with Apache RAT by lidavidm · Pull Request #430 · apache/arrow-java · GitHub

/ arrow-java Public

GH-10: Add basic pre-commit-config with Apache RAT - #430

Merged
kou merged 1 commit into
apache:mainfrom
lidavidm:gh-10
Nov 28, 2024
ConversationCommits (1)ChecksFiles changed
Merged

GH-10: Add basic pre-commit-config with Apache RAT#430
kou merged 1 commit into
apache:mainfrom
lidavidm:gh-10

Conversation

lidavidm commented Nov 28, 2024

Copy link
Copy Markdown
Member

Fixes #10.

lidavidm commented Nov 28, 2024

Copy link
Copy Markdown
Member Author

Ah, I should add the CI check too

lidavidm marked this pull request as ready for review November 28, 2024 00:53
kou approved these changes Nov 28, 2024
View reviewed changes

kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1

kou merged commit 61f7b1e into apache:main Nov 28, 2024
lidavidm deleted the gh-10 branch November 28, 2024 01:59

lidavidm commented Nov 28, 2024

Copy link
Copy Markdown
Member Author

Weird, it seems --all-files does not pass in other PRs, let me see...

lidavidm commented Nov 28, 2024

Copy link
Copy Markdown
Member Author

I think the merge didn't account for pre-commit, should hopefully be fixed in #432

lidavidm mentioned this pull request Nov 29, 2024
Closed
kiszk reviewed Dec 1, 2024
View reviewed changes
Comment thread .pre-commit-config.yaml
entry: |
bash -c " \
git archive HEAD \
--prefix=apache-arrow-go/ \

kiszk Dec 1, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am not familiar with this tool. But is it better to use java instead of go?

kou Dec 1, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch!
We should use "java" here.

lidavidm Dec 1, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah sorry, I copy-pasted and didn't check 😅

lidavidm added this to the 18.2.0 milestone Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kou kou approved these changes
kiszk kiszk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.2.0

Development

Successfully merging this pull request may close these issues.

pre-commit: ShellCheck

3 participants

Back | FazBrowse Home | New Git URL