GH-7: Add macOS, Windows CI - #432
Merged
kou merged 10 commits intoNov 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hmm, macOS realpath is not as capable |
Sorry, something went wrong.
lidavidm
marked this pull request as ready for review
November 28, 2024 03:12
raulcd
reviewed
Nov 28, 2024
raulcd
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Just a minor thing but all the rest looks good to me
Sorry, something went wrong.
Comment thread
.github/workflows/test.yml
Outdated
raulcd
reviewed
Nov 28, 2024
Comment thread
.github/workflows/test.yml
| - arch: AArch64 | ||
| jdk: 11 | ||
| macos: latest | ||
| include: |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
oops, I missed that :)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Updated, tests all pass
Sorry, something went wrong.
kou
approved these changes
Nov 29, 2024
kou
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
+1
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7.
Fixes #8.