Repository navigation
Removed unnecessary @Local annotations and their respective imports - #1102
asfgit merged 1 commit into
Conversation
Sorry, something went wrong.
…rom the ComponentLifecycleBase class and its subclasses.
|
LGTM, based on a set of tests that I run on this branch. Screenshot is from an experimental Jenkins job (that runs the same tests I did manually until now). These test may not cover your change, all they do is show you didn't break them. Someone else needs to review the code.
|
Sorry, something went wrong.
|
LGTM, checked the code. It felt like skimming at times as 607 lines were removed ;) I don't think there is any problem though. |
Sorry, something went wrong.
…-006 Removed unnecessary @Local annotations and their respective importsFollowing @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase class and its subclasses seeking a reduction of a few hundred lines of useless code. I had already opened a pull request for this (#853) but at some point my commit disappeared from the PR entirely, showing no new changes in code, which caused it to be merged automatically (with no changes). * pr/1102: Removed unnecessary @Local annotations and their respective imports from the ComponentLifecycleBase class and its subclasses. Signed-off-by: Remi Bergsma <github@remi.nl>
|
@cristofolini github doesn't show JuniperSRXExternalFirewallElement. It has a syntax error. Did you compile this? and did you use -Dnoredist? that part would have probably revealed the error. I am busy creating a fix |
Sorry, something went wrong.
|
@DaanHoogland, Sorry for the trouble. |
Sorry, something went wrong.
Following @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase class and its subclasses seeking a reduction of a few hundred lines of useless code.
I had already opened a pull request for this (#853) but at some point my commit disappeared from the PR entirely, showing no new changes in code, which caused it to be merged automatically (with no changes).