FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Removed unnecessary @Local annotations and their respective imports by cristofolini · Pull Request #853 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Removed unnecessary @Local annotations and their respective imports - #853

Merged
asfgit merged 0 commit into
apache:masterfrom
rafaelweingartner:master-lrg-cs-hackday-006
Oct 21, 2015
ConversationCommits (0)ChecksFiles changed
Merged

Removed unnecessary @Local annotations and their respective imports#853
asfgit merged 0 commit into
apache:masterfrom
rafaelweingartner:master-lrg-cs-hackday-006

Conversation

cristofolini commented Sep 19, 2015

Copy link
Copy Markdown
Contributor

Following @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports seeking a reduction of a few hundred lines of useless code.

asfbot commented Sep 19, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #657 SUCCESS
This pull request looks good

asfbot commented Sep 19, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #606 FAILURE
Looks like there's a problem with this pull request

asfbot commented Sep 19, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #661 SUCCESS
This pull request looks good

asfbot commented Sep 19, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #610 FAILURE
Looks like there's a problem with this pull request

rafaelweingartner commented Sep 19, 2015

Copy link
Copy Markdown
Member

Hi @critofolini, I think that there was a problem in your PR in class: SecurityGroupManagerImpl

asfbot commented Sep 19, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #662 SUCCESS
This pull request looks good

asfbot commented Sep 19, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #611 FAILURE
Looks like there's a problem with this pull request

asfbot commented Sep 20, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #664 SUCCESS
This pull request looks good

asfbot commented Sep 20, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #613 FAILURE
Looks like there's a problem with this pull request

asfbot commented Sep 20, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #665 SUCCESS
This pull request looks good

asfbot commented Sep 20, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #614 SUCCESS
This pull request looks good

rafaelweingartner commented Sep 20, 2015

Copy link
Copy Markdown
Member

@cristofolini, could you squash your commits into a single one?

cristofolini force-pushed the master-lrg-cs-hackday-006 branch from 9e4e17d to b4c8db4 Compare September 20, 2015 17:14

asfbot commented Sep 20, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #666 SUCCESS
This pull request looks good

cristofolini commented Sep 20, 2015

Copy link
Copy Markdown
Contributor Author

@rafaelweingartner Done.

asfbot commented Sep 20, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #615 SUCCESS
This pull request looks good

rafaelweingartner force-pushed the master-lrg-cs-hackday-006 branch from b4c8db4 to a5ca762 Compare October 20, 2015 17:47
asfgit merged commit a5ca762 into apache:master Oct 21, 2015
cristofolini mentioned this pull request Nov 21, 2015
Merged
asfgit pushed a commit that referenced this pull request Nov 23, 2015
Merge pull request #1102 from rafaelweingartner/master-lrg-cs-hackday…
a6b6f41 
…-006

Removed unnecessary @Local annotations and their respective importsFollowing @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase class and its subclasses seeking a reduction of a few hundred lines of useless code.

I had already opened a pull request for this (#853) but at some point my commit disappeared from the PR entirely, showing no new changes in code, which caused it to be merged automatically (with no changes).

* pr/1102:
  Removed unnecessary @Local annotations and their respective imports from the ComponentLifecycleBase class and its subclasses.

Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL