FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update GUI Kubernetes logo by erikbocks · Pull Request #11895 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Update GUI Kubernetes logo - #11895

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
scclouds:fix-kubernetes-logo
Nov 11, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Update GUI Kubernetes logo#11895
DaanHoogland merged 1 commit into
apache:mainfrom
scclouds:fix-kubernetes-logo

Conversation

erikbocks commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator

Description

Currently, the icon displayed for Kubernetes in the GUI is a Buddhist dharmachakra. This PR fixes this by changing the icon displayed in the GUI to the official Kubernetes logo.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

The icon displayed before the changes:

Before

After the changes:

After

How Has This Been Tested?

After changing the icon, I ran the UI locally by using npm run serve, then validated that the new icon was displayed correctly in the Compute, Create and Images tabs.

How did you try to break this feature and the system with this change?

codecov Bot commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (ec533cd) to head (d44b8f9).
⚠️ Report is 122 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11895      +/-   ##
============================================
+ Coverage     17.42%   17.56%   +0.13%     
- Complexity    15336    15532     +196     
============================================
  Files          5892     5909      +17     
  Lines        526521   529014    +2493     
  Branches      64293    64604     +311     
============================================
+ Hits          91767    92915    +1148     
- Misses       424401   425652    +1251     
- Partials      10353    10447      +94
Flag Coverage Δ
uitests 3.58% <ø> (-0.03%) ⬇️
unittests 18.63% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland approved these changes Oct 23, 2025
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

Comment thread ui/src/components/header/CreateMenu.vue Resolved
hsato03 approved these changes Nov 11, 2025
View reviewed changes

hsato03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

DaanHoogland commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Nov 11, 2025

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Nov 11, 2025

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11895 (QA-JID-794)

DaanHoogland added this to the 4.23 milestone Nov 11, 2025
DaanHoogland merged commit 23fb0e2 into apache:main Nov 11, 2025

shwstppr commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

@DaanHoogland pre-commit GHA was failing in this PR

DaanHoogland commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

@DaanHoogland pre-commit GHA was failing in this PR

D%^% missed that.

it is actually a bit of a problem in the hook (definition):

- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing ui/src/assets/icons/kubernetes.svg

Should we exclude svg files?

DaanHoogland mentioned this pull request Nov 12, 2025
Merged
14 tasks
ribafish added a commit to ribafish/apache-cloudstack that referenced this pull request Nov 14, 2025
Merge branch 'main' into gk/develocityIntegration
2f8416d 
* main: (1223 commits)
  Standardize and auto add license headers for SQL files with pre-commit (apache#12071)
  pre-commit use colored text in the CI for `pass / fail / skipped` (apache#11977)
  ui(locales): remove duplicates and fix typos (apache#11872)
  pre-commit: auto add table of contents with `doctoc` (apache#11679)
  chore: rename workflow `linter.yml` to `pre-commit.yml` (apache#11647)
  engine-schema: upgrade path for 4.23.0 (apache#12048)
  Fixes:apache#7837: Add isolationMethods and vlan to TrafficTypeResponse (apache#8151)
  Svgs (apache#12051)
  Update GUI Kubernetes logo (apache#11895)
  Keeping consistency with other error messages. (apache#11649)
  enhancement: add instance info as Libvirt metadata (apache#11061)
  Add empty Provider value in Network/VPC Offering form (apache#11982)
  merge fix
  Updating pom.xml version numbers for release 4.23.0.0-SNAPSHOT
  Updating pom.xml version numbers for release 4.22.1.0-SNAPSHOT
  UI: fix typo Upload SSL certificate (apache#11869)
  api/test: fix storage pool update with only id (apache#11897)
  Updating pom.xml version numbers for release 4.22.0.0
  Handle null mountTimeout in RestoreBackupCommand (apache#11944)
  Fix the config 'powerflex.connect.on.demand' description (apache#11926)
  ...
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 11, 2025
Update GUI Kubernetes logo (apache#11895)
9d8ff86
owsferraro pushed a commit to owsferraro/cloudstack that referenced this pull request Mar 25, 2026
Update GUI Kubernetes logo (apache#11895)
4e1cd97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
hsato03 hsato03 approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL