FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add empty Provider value in Network/VPC Offering form by Pearl1594 · Pull Request #11982 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Add empty Provider value in Network/VPC Offering form - #11982

Merged
DaanHoogland merged 1 commit into
mainfrom
add-empty-provider-offering
Nov 6, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Add empty Provider value in Network/VPC Offering form#11982
DaanHoogland merged 1 commit into
mainfrom
add-empty-provider-offering

Conversation

Pearl1594 commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes: #11975
This PR adds empty value in the Providers drop down menu in the Network / VPC Offering creation form to prevent it from being mistaken to be a mandatory field.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov Bot commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.56%. Comparing base (15c2e50) to head (99e3aa6).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #11982   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
- Complexity    15543    15545    +2     
=========================================
  Files          5909     5909           
  Lines        529056   529056           
  Branches      64617    64617           
=========================================
+ Hits          92947    92948    +1     
  Misses       425654   425654           
+ Partials      10455    10454    -1
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.63% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sonarqubecloud Bot commented Nov 4, 2025

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

DaanHoogland commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented Nov 5, 2025

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented Nov 5, 2025

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11982 (QA-JID-790)

DaanHoogland approved these changes Nov 5, 2025
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm, verified in qa.c.c

DaanHoogland added this to the 4.23 milestone Nov 5, 2025
kiranchavala approved these changes Nov 6, 2025
View reviewed changes

kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, Tested on the qa simulator

DaanHoogland changed the base branch from main to 4.22 November 6, 2025 10:06
DaanHoogland changed the base branch from 4.22 to main November 6, 2025 10:07
DaanHoogland merged commit a50de02 into main Nov 6, 2025
DaanHoogland deleted the add-empty-provider-offering branch November 6, 2025 10:09
abh1sar pushed a commit to shapeblue/cloudstack that referenced this pull request Nov 7, 2025
Add empty Provider value in Network/VPC Offering form (apache#11982)
8710c48
ribafish added a commit to ribafish/apache-cloudstack that referenced this pull request Nov 14, 2025
Merge branch 'main' into gk/develocityIntegration
2f8416d 
* main: (1223 commits)
  Standardize and auto add license headers for SQL files with pre-commit (apache#12071)
  pre-commit use colored text in the CI for `pass / fail / skipped` (apache#11977)
  ui(locales): remove duplicates and fix typos (apache#11872)
  pre-commit: auto add table of contents with `doctoc` (apache#11679)
  chore: rename workflow `linter.yml` to `pre-commit.yml` (apache#11647)
  engine-schema: upgrade path for 4.23.0 (apache#12048)
  Fixes:apache#7837: Add isolationMethods and vlan to TrafficTypeResponse (apache#8151)
  Svgs (apache#12051)
  Update GUI Kubernetes logo (apache#11895)
  Keeping consistency with other error messages. (apache#11649)
  enhancement: add instance info as Libvirt metadata (apache#11061)
  Add empty Provider value in Network/VPC Offering form (apache#11982)
  merge fix
  Updating pom.xml version numbers for release 4.23.0.0-SNAPSHOT
  Updating pom.xml version numbers for release 4.22.1.0-SNAPSHOT
  UI: fix typo Upload SSL certificate (apache#11869)
  api/test: fix storage pool update with only id (apache#11897)
  Updating pom.xml version numbers for release 4.22.0.0
  Handle null mountTimeout in RestoreBackupCommand (apache#11944)
  Fix the config 'powerflex.connect.on.demand' description (apache#11926)
  ...
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 11, 2025
Add empty Provider value in Network/VPC Offering form (apache#11982)
f24dbe8
owsferraro pushed a commit to owsferraro/cloudstack that referenced this pull request Mar 25, 2026
Add empty Provider value in Network/VPC Offering form (apache#11982)
fe967d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kiranchavala kiranchavala approved these changes
DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.23.0

Development

Successfully merging this pull request may close these issues.

UI: Provide the old toggle option in create vpc offering form for network providers ( NSX, Netris)

4 participants

Back | FazBrowse Home | New Git URL