FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

kvm: get ip address of Windows vms via virsh domifaddr by weizhouapache · Pull Request #12651 · apache/cloudstack · GitHub

/ cloudstack Public

kvm: get ip address of Windows vms via virsh domifaddr - #12651

Merged
DaanHoogland merged 2 commits into
apache:4.22from
weizhouapache:4.22-fix-ip-addr-of-windows-vm
Jul 1, 2026
ConversationCommits (2)ChecksFiles changed
Merged

kvm: get ip address of Windows vms via virsh domifaddr#12651
DaanHoogland merged 2 commits into
apache:4.22from
weizhouapache:4.22-fix-ip-addr-of-windows-vm

Conversation

weizhouapache commented Feb 16, 2026

Copy link
Copy Markdown
Member

Description

This PR fixes #12649

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache linked an issue Feb 16, 2026 that may be closed by this pull request
KVM IP autodiscovery not working with Windows interface names #12649
Closed
weizhouapache added this to the 4.22.1 milestone Feb 16, 2026

codecov Bot commented Feb 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.66%. Comparing base (097a579) to head (9fbdb44).

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #12651      +/-   ##
============================================
- Coverage     17.66%   17.66%   -0.01%     
  Complexity    15793    15793              
============================================
  Files          5923     5923              
  Lines        533309   533309              
  Branches      65237    65237              
============================================
- Hits          94229    94227       -2     
- Misses       428434   428435       +1     
- Partials      10646    10647       +1
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.74% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI reviewed Feb 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pull request overview

This PR fixes issue #12649 where KVM IP autodiscovery failed for Windows VMs due to multi-word interface names like "Ethernet Instance 0". The fix changes the parsing logic in getIpAddresses to parse virsh domifaddr output from the end of each line rather than from fixed positions, making it compatible with both single-word Linux interface names and multi-word Windows interface names.

Changes:

  • Modified parsing logic to use relative positions from end of line (parts.length - 3, parts.length - 2, parts.length - 1) instead of fixed positions
  • Added test data constant VIRSH_DOMIF_OUTPUT_WINDOWS with realistic Windows virsh output
  • Updated testExecuteWithWindowsVm to test parsing of Windows interface names with spaces

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
LibvirtGetVmIpAddressCommandWrapper.java Changed parsing to use relative positions from end of line to handle multi-word interface names
LibvirtGetVmIpAddressCommandWrapperTest.java Added Windows-specific test data and updated/added tests for Windows VM IP discovery

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .../java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapperTest.java
Comment thread .../java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtGetVmIpAddressCommandWrapperTest.java

weizhouapache commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

for anyone who use 4.22.0.0, please rename the .jar.zip file to .jar, and replace /usr/share/cloudstack-agent/lib/cloud-plugin-hypervisor-kvm-4.22.0.0.jar with it on kvm hosts.

cloud-plugin-hypervisor-kvm-4.22.0.0.jar.zip

sureshanaparti commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

@weizhouapache is it ready for review and testing?

weizhouapache marked this pull request as ready for review February 26, 2026 12:56

weizhouapache commented Feb 26, 2026

Copy link
Copy Markdown
Member Author

@weizhouapache is it ready for review and testing?

@sureshanaparti
yes, just marked it as "ready for review"

sureshanaparti modified the milestones: 4.22.1, 4.22.2 Apr 24, 2026
NuxRo approved these changes Jun 30, 2026
View reviewed changes

NuxRo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm, confirmed by myself as well as a 3rd party

DaanHoogland approved these changes Jul 1, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm

DaanHoogland merged commit 348ceaf into apache:4.22 Jul 1, 2026
26 checks passed
DaanHoogland deleted the 4.22-fix-ip-addr-of-windows-vm branch July 1, 2026 18:29
DaanHoogland mentioned this pull request Jul 1, 2026
Closed
harikrishna-patnala mentioned this pull request Jul 2, 2026
Merged
14 tasks
harikrishna-patnala added a commit to shapeblue/cloudstack that referenced this pull request Jul 6, 2026
Merge pull request #138 from shapeblue/ha-checkonhostanswer-fix-4.22.1
f39b852 
[4.22.1.0-shapeblue1] Upstream PRs apache#13373 and apache#12651
weizhouapache mentioned this pull request Jul 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
NuxRo NuxRo approved these changes
DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:kvm

Projects

None yet

Milestone

4.22.2

Development

Successfully merging this pull request may close these issues.

KVM IP autodiscovery not working with Windows interface names

6 participants

Back | FazBrowse Home | New Git URL