FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[4.22.1.0-shapeblue1] Upstream PRs #13373 and #12651 by harikrishna-patnala · Pull Request #138 · shapeblue/cloudstack · GitHub

/ cloudstack Public
forked from apache/cloudstack

[4.22.1.0-shapeblue1] Upstream PRs #13373 and #12651 - #138

Merged
harikrishna-patnala merged 5 commits into
4.22.1.0-shapeblue1from
ha-checkonhostanswer-fix-4.22.1
Jul 6, 2026
ConversationCommits (5)ChecksFiles changed
Merged

[4.22.1.0-shapeblue1] Upstream PRs #13373 and #12651#138
harikrishna-patnala merged 5 commits into
4.22.1.0-shapeblue1from
ha-checkonhostanswer-fix-4.22.1

Conversation

harikrishna-patnala commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR is a duplicate of upstream PRs apache#13373 and apache#12651 to address the same in the ShapeBlue custom patch 4.22.1.0-shapeblue1

cc @sureshanaparti

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

harikrishna-patnala commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

@blueorangutan package

harikrishna-patnala changed the title [4.22.1.0-shapeblue1] KVM HA: Fix CheckOnHostAnswer success flag when there is no heartbeat [4.22.1.0-shapeblue1] KVM HA fixes #13373 and #13377 Jun 19, 2026
harikrishna-patnala mentioned this pull request Jun 19, 2026
Closed
14 tasks
harikrishna-patnala force-pushed the ha-checkonhostanswer-fix-4.22.1 branch from 5025f5d to 1613b41 Compare June 19, 2026 04:24

kiranchavala commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@weizhouapache @NuxRo @rajujith @sureshanaparti @harikrishna-patnala @andrijapanicsb

what should be the expected behaviour of vm ha in case of soft power off the kvm host

Steps to reproduce the issue

  1. Create a HA enabled offering
  2. Deploy a vm with HA enabled offering on a kvm host 1
  3. Login to the kvm host 1
  4. Issue shutdown command
  5. VM HA doesn't get triggered
  6. Global setting value : commands.timeout = CheckHealthCommand=5,CheckOnHostCommand=5
[root@ref-trl-11991-k-Mol8-kiran-chavala-kvm1 ~]# virsh list
 Id   Name       State
--------------------------
 1    i-2-6-VM   running

[root@ref-trl-11991-k-Mol8-kiran-chavala-kvm1 ~]# shutdown now
Connection to 10.0.32.193 closed by remote host.
Connection to 10.0.32.193 closed.
  1. Host goes into disconnected state
  2. No entry created in ( select * from op_ha_work) table
  3. grep "status reported from itself" /var/log/cloudstack/management/management-server.log

VM HA gets triggered only if hard power-off a KVM host

weizhouapache commented Jun 19, 2026

Copy link
Copy Markdown
Member

if Host goes into disconnected state, VM HA will NOT be triggered.
It is a known issue, we will address in a customer FR.

kiranchavala commented Jun 24, 2026

Copy link
Copy Markdown
Member

@blueorangutan test

harikrishna-patnala force-pushed the ha-checkonhostanswer-fix-4.22.1 branch from 1613b41 to 7846800 Compare July 2, 2026 04:43
harikrishna-patnala changed the title [4.22.1.0-shapeblue1] KVM HA fixes #13373 and #13377 [4.22.1.0-shapeblue1] Upstream PRs #13373 and #13377 Jul 2, 2026
harikrishna-patnala changed the title [4.22.1.0-shapeblue1] Upstream PRs #13373 and #13377 [4.22.1.0-shapeblue1] Upstream PRs #13373 and #12651 Jul 2, 2026
kiranchavala approved these changes Jul 6, 2026
View reviewed changes

kiranchavala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Tested manually , the vm ha feature

The vm ha kicks in as soon as the agent is status is reported as Down

harikrishna-patnala merged commit f39b852 into 4.22.1.0-shapeblue1 Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kiranchavala kiranchavala approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL