FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify VMware import conversion storage option by andrijapanicsb · Pull Request #13165 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Clarify VMware import conversion storage option - #13165

Merged
nvazquez merged 1 commit into
apache:mainfrom
andrijapanicsb:fix-vmware-import-temp-conversion-storage
Nov 9, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Clarify VMware import conversion storage option#13165
nvazquez merged 1 commit into
apache:mainfrom
andrijapanicsb:fix-vmware-import-temp-conversion-storage

Conversation

andrijapanicsb commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This updates the VMware-to-KVM import form copy for the optional conversion storage selector.

The previous label used "staging storage", which can be confused with CloudStack secondary staging storage. In this flow, the selected storage is the temporary location where virt-v2v writes converted disks before CloudStack imports them to the destination storage pool.

Changes

  • Rename the selector text to "(Optional) Select temporary conversion storage".
  • Add a tooltip explaining that virt-v2v temporarily writes converted disks there before import.
  • Add an optional tooltip prop to CheckBoxSelectPair so this can be shown next to the checkbox label.

Testing

  • Parsed ui/public/locales/en.json successfully with Node.
  • Ran git diff --check successfully.

Related documentation PR: apache/cloudstack-documentation#651 (#651).

andrijapanicsb force-pushed the fix-vmware-import-temp-conversion-storage branch from 4620b77 to a02a8de Compare May 14, 2026 23:56

codecov Bot commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.09%. Comparing base (5893ba5) to head (a02a8de).
⚠️ Report is 448 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #13165   +/-   ##
=========================================
  Coverage     18.09%   18.09%           
  Complexity    16723    16723           
=========================================
  Files          6037     6037           
  Lines        542580   542580           
  Branches      66427    66427           
=========================================
+ Hits          98155    98157    +2     
+ Misses       433399   433398    -1     
+ Partials      11026    11025    -1
Flag Coverage Δ
uitests 3.51% <ø> (ø)
unittests 19.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

andrijapanicsb mentioned this pull request May 15, 2026
Merged

DaanHoogland commented May 20, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan ui

blueorangutan commented May 20, 2026

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented May 20, 2026

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/13165 (QA-JID-927)

DaanHoogland approved these changes May 21, 2026
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

clgtm, cannot be tested in QA

weizhouapache added this to the 4.24.0 milestone Jun 29, 2026
DaanHoogland moved this from Backlog to Ready in CloudStack Testing Aug 31, 2026
nvazquez approved these changes Nov 9, 2026
View reviewed changes

nvazquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nvazquez merged commit bc5522e into apache:main Nov 9, 2026
51 of 53 checks passed
github-project-automation Bot moved this from Ready to Done in CloudStack Testing Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DaanHoogland DaanHoogland approved these changes
nvazquez nvazquez approved these changes
sureshanaparti Awaiting requested review from sureshanaparti
kiwiflyer Awaiting requested review from kiwiflyer
wido Awaiting requested review from wido

Assignees

No one assigned

Labels

component:UI status:needs-testing

Projects

CloudStack Testing
Status: Done

Milestone

24.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL