FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CLOUDSTACK-8703: Fixed issue when listing directory on S3. by borisroman · Pull Request #651 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

CLOUDSTACK-8703: Fixed issue when listing directory on S3. - #651

Merged
asfgit merged 1 commit into
apache:masterfrom
borisroman:CLOUDSTACK-8703
Aug 4, 2015
ConversationCommits (1)ChecksFiles changed
Merged

CLOUDSTACK-8703: Fixed issue when listing directory on S3.#651
asfgit merged 1 commit into
apache:masterfrom
borisroman:CLOUDSTACK-8703

Conversation

borisroman commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

It would only return objectSummaries when the anwser from the S3 System was truncated. Due to: debcbcc

CLOUDSTACK-8703: Fixed issue when listing directory on S3, it would o…
5f87e9c 
…nly return objectSummaries when the anwser from the S3 System was truncated.

remibergsma commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

The failing check is a Travis timeout. Seems not related, is it?

DaanHoogland reviewed Aug 3, 2015
View reviewed changes
Comment thread utils/src/com/cloud/utils/S3Utils.java

DaanHoogland Aug 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

is ol guaranteed not to be null? I don't see any specific remark on this in the amazon javadoc.

borisroman Aug 3, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is, it will thrown an exception not return null.

DaanHoogland commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

@borisroman @remibergsma the timeout is not related to anything but travis and maybe to the way we use it

DaanHoogland commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

thanks for the comments Boris LGTM

remibergsma commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

I cannot test the functionality myself right now, although it looks OK. @wido can you verify and give a final LGTM? I'll then merge it.

@borisroman my only comment is your commit message. Please use 50 chars or less on the first line (as a title), then an empty line and finally any extra info or a description.

Example:
Fixed issue when listing directory on S3

CLOUDSTACK-8703: It would only return objectSummaries when the anwser from the S3 System was truncated.

DaanHoogland commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

@remibergsma Are you sure you don't want the issue ref on the first line?

CLOUDSTACK-8703: Fixed issue when listing directory on S3

It would only return objectSummaries when the anwser from the S3 System was truncated.

asfbot commented Aug 3, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #187 ABORTED

remibergsma commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

@DaanHoogland If it fits, its OK. Usually when people do this, it doesn't fit any more and GitHub will cut it. If the issue id is in the body, you can still search for it.

wido commented Aug 3, 2015

Copy link
Copy Markdown
Contributor

@remibergsma I will look at this with @borisroman tomorrow at the office. I want to verify his logic. Code seems good for now.

asfbot commented Aug 3, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #885 ABORTED

asfbot commented Aug 3, 2015

Copy link
Copy Markdown

cloudstack-pull-analysis #120 SUCCESS
This pull request looks good

wido commented Aug 4, 2015

Copy link
Copy Markdown
Contributor

Reviewed the code. LGTM

asfgit merged commit 5f87e9c into apache:master Aug 4, 2015
asfgit pushed a commit that referenced this pull request Aug 4, 2015
#651 (@borisroman) CLOUDSTACK-8703: Fixed issue when listing direct..
7b47c49 
* pr/651:
  CLOUDSTACK-8703: Fixed issue when listing directory on S3, it would only return objectSummaries when the anwser from the S3 System was truncated.

Signed-off-by: Remi Bergsma <github@remi.nl>
asfgit pushed a commit that referenced this pull request Aug 4, 2015
CLOUDSTACK-8703: Fixed issue when listing directory on S3, it would o…
58c6a8d 
…nly return objectSummaries when the anwser from the S3 System was truncated.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #651
borisroman deleted the CLOUDSTACK-8703 branch August 4, 2015 15:46
yadvr pushed a commit that referenced this pull request Jan 20, 2021
Prevent form from closing if validation fails (#651)
070cbc1 
* Prevent form from closing if validation fails

* Prevent closing on failure for custom forms

* Fixing group actions

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
winterhazel pushed a commit that referenced this pull request Jan 28, 2026
Merge branch 'fix-quota-apis-transaction' into '4.20.0.0-scclouds'
a29140d 
Correção em transação nas APIs do Quota

Closes #651

See merge request scclouds/scclouds!1160
andrijapanicsb mentioned this pull request May 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL