FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind by sureshanaparti · Pull Request #2090 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind - #2090

Closed
sureshanaparti wants to merge 1 commit into
masterfrom
unknown repository
ConversationCommits (1)ChecksFiles changed
Closed

CLOUDSTACK-8415 [VMware] SSVM shutdown during snapshot operation results in disks to be left behind#2090
sureshanaparti wants to merge 1 commit into
masterfrom
unknown repository

Conversation

sureshanaparti commented May 9, 2017 •
edited by PaulAngus
Loading

Copy link
Copy Markdown
Contributor

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

In VMware environment, SSVM shutdown during snapshot operation leaves behind partial, unusable disks in secondary storage and VM snapshots.

Fix: Enhance storage garbage collector to delete the partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot.

This closes #540

sureshanaparti mentioned this pull request May 9, 2017
Closed

sureshanaparti commented May 9, 2017

Copy link
Copy Markdown
Contributor Author

@DaanHoogland @wilderrodrigues Please review the changes.

sureshanaparti commented May 10, 2017

Copy link
Copy Markdown
Contributor Author

@borisstoyanov Can you please kick off VMware trillian tests

borisstoyanov commented May 10, 2017

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented May 10, 2017

Copy link
Copy Markdown

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented May 10, 2017

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-705

borisstoyanov commented May 10, 2017

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented May 10, 2017

Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov commented May 11, 2017

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented May 11, 2017

Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland requested changes May 11, 2017
View reviewed changes

DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

the functionality is good but shouldn't be in here. It is vmware specific and we should move away from closely tighing storage to hypervisors.

Comment thread server/src/com/cloud/storage/StorageManagerImpl.java Outdated
for (SnapshotVO snapshotVO : snapshots) {
try {
List<SnapshotDataStoreVO> storeRefs = _snapshotStoreDao.findBySnapshotId(snapshotVO.getId());
boolean isVMware = snapshotVO.getHypervisorType().equals(HypervisorType.VMware);

DaanHoogland May 11, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please try to move this logic into the vmware plugin. this code should remain generic.
opinions @mike-tutkowski @swill @rhtyd ?

mike-tutkowski May 15, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

While I believe your comment makes sense, @DaanHoogland, it appears this file has hypervisor-specific logic sprinkled all around it.

Perhaps it would be better to allow this here and for you to write up a bug noting that it would be ideal for this file to be hypervisor agnostic?

sureshanaparti May 17, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DaanHoogland @mike-tutkowski Partial disks are left behind in VMware env when SSVM is shutdown/destroyed. So, DeleteSnapshotsDirCommand for Image store and DeleteVMSnapshotCommand for Primary store (to remove worker VM snapshot) has been triggered in VMware env here to cleanup the partial disks created in secondary storage and VM snapshots in primary respectively. The VMware storage manager would cleanup the worker VM snapshot from DeleteVMSnapshotCommand. No VMware specific code here, except sending these commands for cleanup.

Comment thread server/src/com/cloud/storage/StorageManagerImpl.java Outdated
}
}
if (removeSnapshot) {
_snapshotDao.expunge(snapshotVO.getId());

DaanHoogland May 11, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this method is already to long.
please factor out the new part into a seperate method.

sureshanaparti May 17, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@DaanHoogland moved to a private method removeSnapshot()

blueorangutan commented May 11, 2017

Copy link
Copy Markdown

Trillian test result (tid-1075)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39573 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2090-t1075-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 49 look ok, 2 have error(s)

Test Result Time (s) Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 435.10 test_vpc_redundant.py
test_04_rvpc_privategw_static_routes Failure 421.56 test_privategw_acl.py
test_01_vpc_site2site_vpn Success 215.62 test_vpc_vpn.py
test_01_vpc_remote_access_vpn Success 96.39 test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn Success 301.30 test_vpc_vpn.py
test_02_VPC_default_routes Success 326.88 test_vpc_router_nics.py
test_01_VPC_nics_after_destroy Success 680.39 test_vpc_router_nics.py
test_05_rvpc_multi_tiers Success 558.21 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Success 1493.79 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Success 656.46 test_vpc_redundant.py
test_02_redundant_VPC_default_routes Success 903.85 test_vpc_redundant.py
test_09_delete_detached_volume Success 156.78 test_volumes.py
test_08_resize_volume Success 156.56 test_volumes.py
test_07_resize_fail Success 161.62 test_volumes.py
test_06_download_detached_volume Success 156.46 test_volumes.py
test_05_detach_volume Success 150.82 test_volumes.py
test_04_delete_attached_volume Success 151.32 test_volumes.py
test_03_download_attached_volume Success 156.47 test_volumes.py
test_02_attach_volume Success 90.92 test_volumes.py
test_01_create_volume Success 742.38 test_volumes.py
test_03_delete_vm_snapshots Success 275.23 test_vm_snapshots.py
test_02_revert_vm_snapshots Success 105.85 test_vm_snapshots.py
test_01_create_vm_snapshots Success 169.13 test_vm_snapshots.py
test_deploy_vm_multiple Success 368.62 test_vm_life_cycle.py
test_deploy_vm Success 0.03 test_vm_life_cycle.py
test_advZoneVirtualRouter Success 0.03 test_vm_life_cycle.py
test_10_attachAndDetach_iso Success 26.93 test_vm_life_cycle.py
test_09_expunge_vm Success 125.27 test_vm_life_cycle.py
test_08_migrate_vm Success 30.97 test_vm_life_cycle.py
test_07_restore_vm Success 0.14 test_vm_life_cycle.py
test_06_destroy_vm Success 125.89 test_vm_life_cycle.py
test_03_reboot_vm Success 125.96 test_vm_life_cycle.py
test_02_start_vm Success 10.20 test_vm_life_cycle.py
test_01_stop_vm Success 35.37 test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName Success 161.47 test_templates.py
test_08_list_system_templates Success 0.03 test_templates.py
test_07_list_public_templates Success 0.04 test_templates.py
test_05_template_permissions Success 0.06 test_templates.py
test_04_extract_template Success 5.24 test_templates.py
test_03_delete_template Success 5.11 test_templates.py
test_02_edit_template Success 90.15 test_templates.py
test_01_create_template Success 110.95 test_templates.py
test_10_destroy_cpvm Success 197.34 test_ssvm.py
test_09_destroy_ssvm Success 193.91 test_ssvm.py
test_08_reboot_cpvm Success 132.06 test_ssvm.py
test_07_reboot_ssvm Success 134.63 test_ssvm.py
test_06_stop_cpvm Success 162.21 test_ssvm.py
test_05_stop_ssvm Success 163.98 test_ssvm.py
test_04_cpvm_internals Success 1.33 test_ssvm.py
test_03_ssvm_internals Success 4.83 test_ssvm.py
test_02_list_cpvm_vm Success 0.16 test_ssvm.py
test_01_list_sec_storage_vm Success 0.15 test_ssvm.py
test_02_list_snapshots_with_removed_data_store Success 203.14 test_snapshots.py
test_01_snapshot_root_disk Success 16.42 test_snapshots.py
test_04_change_offering_small Success 240.82 test_service_offerings.py
test_03_delete_service_offering Success 0.04 test_service_offerings.py
test_02_edit_service_offering Success 0.08 test_service_offerings.py
test_01_create_service_offering Success 0.13 test_service_offerings.py
test_02_sys_template_ready Success 0.15 test_secondary_storage.py
test_01_sys_vm_start Success 0.21 test_secondary_storage.py
test_09_reboot_router Success 45.38 test_routers.py
test_08_start_router Success 35.34 test_routers.py
test_07_stop_router Success 10.17 test_routers.py
test_06_router_advanced Success 0.06 test_routers.py
test_05_router_basic Success 0.05 test_routers.py
test_04_restart_network_wo_cleanup Success 5.79 test_routers.py
test_03_restart_network_cleanup Success 95.80 test_routers.py
test_02_router_internal_adv Success 1.14 test_routers.py
test_01_router_internal_basic Success 0.59 test_routers.py
test_router_dns_guestipquery Success 80.15 test_router_dns.py
test_router_dns_externalipquery Success 0.11 test_router_dns.py
test_router_dhcphosts Success 344.34 test_router_dhcphosts.py
test_router_dhcp_opts Success 22.34 test_router_dhcphosts.py
test_01_updatevolumedetail Success 0.12 test_resource_detail.py
test_01_reset_vm_on_reboot Success 130.95 test_reset_vm_on_reboot.py
test_createRegion Success 0.05 test_regions.py
test_create_pvlan_network Success 5.24 test_pvlan.py
test_dedicatePublicIpRange Success 0.57 test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup Success 601.40 test_privategw_acl.py
test_02_vpc_privategw_static_routes Success 446.13 test_privategw_acl.py
test_01_vpc_privategw_acl Success 117.83 test_privategw_acl.py
test_03_migration_options_storage_tags Success 161.68 test_primary_storage.py
test_02_edit_primary_storage_tags Success 0.10 test_primary_storage.py
test_01_primary_storage_nfs Success 35.91 test_primary_storage.py
test_01_deploy_vms_storage_tags Success 31.24 test_primary_storage.py
test_createPortablePublicIPRange Success 15.23 test_portable_publicip.py
test_createPortablePublicIPAcquire Success 15.67 test_portable_publicip.py
test_isolate_network_password_server Success 92.03 test_password_server.py
test_UpdateStorageOverProvisioningFactor Success 0.16 test_over_provisioning.py
test_oobm_zchange_password Success 30.82 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Success 16.49 test_outofbandmanagement.py
test_oobm_issue_power_status Success 10.45 test_outofbandmanagement.py
test_oobm_issue_power_soft Success 15.39 test_outofbandmanagement.py
test_oobm_issue_power_reset Success 10.37 test_outofbandmanagement.py
test_oobm_issue_power_on Success 10.44 test_outofbandmanagement.py
test_oobm_issue_power_off Success 15.37 test_outofbandmanagement.py
test_oobm_issue_power_cycle Success 10.36 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Success 87.74 test_outofbandmanagement.py
test_oobm_enable_feature_valid Success 0.16 test_outofbandmanagement.py
test_oobm_enable_feature_invalid Success 5.15 test_outofbandmanagement.py
test_oobm_disable_feature_valid Success 5.21 test_outofbandmanagement.py
test_oobm_disable_feature_invalid Success 0.12 test_outofbandmanagement.py
test_oobm_configure_invalid_driver Success 0.09 test_outofbandmanagement.py
test_oobm_configure_default_driver Success 0.10 test_outofbandmanagement.py
test_oobm_background_powerstate_sync Success 23.46 test_outofbandmanagement.py
test_extendPhysicalNetworkVlan Success 15.39 test_non_contigiousvlan.py
test_01_nic Success 459.79 test_nic.py
test_releaseIP Success 318.47 test_network.py
test_reboot_router Success 459.06 test_network.py
test_public_ip_user_account Success 10.25 test_network.py
test_public_ip_admin_account Success 40.28 test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule Success 66.98 test_network.py
test_network_rules_acquired_public_ip_2_nat_rule Success 62.03 test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule Success 123.88 test_network.py
test_delete_account Success 328.19 test_network.py
test_02_port_fwd_on_non_src_nat Success 55.67 test_network.py
test_01_port_fwd_on_src_nat Success 111.83 test_network.py
test_nic_secondaryip_add_remove Success 257.87 test_multipleips_per_nic.py
test_list_zones_metrics Success 0.34 test_metrics_api.py
test_list_volumes_metrics Success 5.55 test_metrics_api.py
test_list_vms_metrics Success 191.77 test_metrics_api.py
test_list_pstorage_metrics Success 0.33 test_metrics_api.py
test_list_infrastructure_metrics Success 0.48 test_metrics_api.py
test_list_hosts_metrics Success 0.40 test_metrics_api.py
test_list_clusters_metrics Success 0.35 test_metrics_api.py
login_test_saml_user Success 19.30 test_login.py
test_assign_and_removal_lb Success 145.90 test_loadbalance.py
test_02_create_lb_rule_non_nat Success 187.79 test_loadbalance.py
test_01_create_lb_rule_src_nat Success 218.63 test_loadbalance.py
test_03_list_snapshots Success 0.09 test_list_ids_parameter.py
test_02_list_templates Success 0.04 test_list_ids_parameter.py
test_01_list_volumes Success 0.03 test_list_ids_parameter.py
test_07_list_default_iso Success 0.06 test_iso.py
test_05_iso_permissions Success 0.08 test_iso.py
test_04_extract_Iso Success 5.16 test_iso.py
test_03_delete_iso Success 95.20 test_iso.py
test_02_edit_iso Success 0.10 test_iso.py
test_01_create_iso Success 21.02 test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Success 209.04 test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Success 172.84 test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 Success 510.36 test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 Success 480.96 test_internal_lb.py
test_dedicateGuestVlanRange Success 10.51 test_guest_vlan_range.py
test_UpdateConfigParamWithScope Success 0.15 test_global_settings.py
test_rolepermission_lifecycle_update Success 6.17 test_dynamicroles.py
test_rolepermission_lifecycle_list Success 6.00 test_dynamicroles.py
test_rolepermission_lifecycle_delete Success 5.88 test_dynamicroles.py
test_rolepermission_lifecycle_create Success 5.93 test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates Success 6.03 test_dynamicroles.py
test_role_lifecycle_update_role_inuse Success 5.92 test_dynamicroles.py
test_role_lifecycle_update Success 5.99 test_dynamicroles.py
test_role_lifecycle_list Success 5.90 test_dynamicroles.py
test_role_lifecycle_delete Success 6.01 test_dynamicroles.py
test_role_lifecycle_create Success 5.94 test_dynamicroles.py
test_role_inuse_deletion Success 5.94 test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers Success 8.18 test_dynamicroles.py
test_role_account_acls Success 8.39 test_dynamicroles.py
test_default_role_deletion Success 6.11 test_dynamicroles.py
test_04_create_fat_type_disk_offering Success 0.10 test_disk_offerings.py
test_03_delete_disk_offering Success 0.04 test_disk_offerings.py
test_02_edit_disk_offering Success 0.05 test_disk_offerings.py
test_02_create_sparse_type_disk_offering Success 0.08 test_disk_offerings.py
test_01_create_disk_offering Success 0.12 test_disk_offerings.py
test_deployvm_userdispersing Success 25.79 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated Success 60.90 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit Success 60.74 test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post Success 10.40 test_deploy_vm_with_userdata.py
test_deployvm_userdata Success 80.95 test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize Success 0.09 test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize Success 0.07 test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize Success 247.02 test_deploy_vm_root_resize.py
test_deploy_vm_from_iso Success 212.48 test_deploy_vm_iso.py
test_06_verify_guest_lspci_again Success 40.45 test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restart Success 10.95 test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci Success 40.51 test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_disk Success 10.82 test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restart Success 131.60 test_deploy_virtio_scsi_vm.py
test_01_verify_libvirt Success 0.56 test_deploy_virtio_scsi_vm.py
test_DeployVmAntiAffinityGroup Success 65.98 test_affinity_groups.py
test_change_service_offering_for_vm_with_snapshots Skipped 0.00 test_vm_snapshots.py
test_06_copy_template Skipped 0.00 test_templates.py
test_static_role_account_acls Skipped 0.03 test_staticroles.py
test_11_ss_nfs_version_on_ssvm Skipped 0.02 test_ssvm.py
test_01_scale_vm Skipped 0.00 test_scale_vm.py
test_01_primary_storage_iscsi Skipped 0.07 test_primary_storage.py
test_nested_virtualization_vmware Skipped 0.00 test_nested_virtualization.py
test_06_copy_iso Skipped 0.00 test_iso.py
test_deploy_vgpu_enabled_vm Skipped 0.04 test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support Skipped 0.04 test_deploy_vgpu_enabled_vm.py

sureshanaparti commented May 19, 2017

Copy link
Copy Markdown
Contributor Author

@DaanHoogland Can you check the changes.

sureshanaparti commented May 30, 2017

Copy link
Copy Markdown
Contributor Author

@DaanHoogland Can you check and confirm the changes.

cloudmonger commented Jun 14, 2017

Copy link
Copy Markdown

ACS CI BVT Run

Sumarry:
Build Number 841
Hypervisor xenserver
NetworkType Advanced
Passed=107
Failed=6
Skipped=12

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

  • test_deploy_vm_iso.py

  • test_deploy_vm_from_iso Failed

  • test_routers_network_ops.py

  • test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 29 runs

  • test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 29 runs

  • test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failing since 29 runs

  • test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failing since 29 runs

  • test_03_RVR_Network_check_router_state Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

sureshanaparti commented Jun 15, 2017

Copy link
Copy Markdown
Contributor Author

ping @DaanHoogland

yadvr added this to the 4.11 milestone Dec 10, 2017
yadvr removed this from the 4.11 milestone Jan 4, 2018

yadvr commented Apr 24, 2018

Copy link
Copy Markdown
Member

ping @sureshanaparti can you fix the conflicts?

DaanHoogland commented Apr 28, 2018

Copy link
Copy Markdown
Contributor

@sureshanaparti sorry for totally missing this. Yes this looks like what I asked for. please rebase as @rhtyd asked so we can test and merge.

DaanHoogland commented Mar 6, 2020

Copy link
Copy Markdown
Contributor

@rhtyd @PaulAngus @andrijapanicsb is this still relevant?

DaanHoogland marked this pull request as draft May 7, 2020 09:26
Humbedooh closed this Jun 11, 2021
Humbedooh deleted the branch apache:master June 11, 2021 09:50

yadvr commented Jun 17, 2021

Copy link
Copy Markdown
Member

Hi, the PR got auto-closed due to no known source repository or some other Github-specific issue during the recent renaming of the default branch to main. If you wish kindly submit a new PR.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mike-tutkowski mike-tutkowski left review comments
DaanHoogland DaanHoogland requested changes

Assignees

No one assigned

Labels

component:ssvm component:vmware status:needs-work status:wip type:bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL