Repository navigation
CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin… - #540
likitha wants to merge 1 commit into
Conversation
Sorry, something went wrong.
…d partial unusable disks and VM snapshots in secondary storage. Enhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot.
|
cloudstack-pull-requests #673 SUCCESS |
Sorry, something went wrong.
|
LGTM 👍 |
Sorry, something went wrong.
There was a problem hiding this comment.
Is this really only true for vmware? It seems that adding a uuid to the path is a rather universal action in the ssvm, no?
Sorry, something went wrong.
There was a problem hiding this comment.
It seems like it should be applied to any hypervisor.
Is that another one we can take in and fix?
Sorry, something went wrong.
|
This seems to me to be a solution for vmware for a more generic problem. in the generic code conditions for hypervisortype == vmware are set while the problem is generic over hypervisor typos. |
Sorry, something went wrong.
There was a problem hiding this comment.
I would also call concat twice: 1 for the "/"; and the 2nd time for the UUID.randomUUID().toString().
Sorry, something went wrong.
There was a problem hiding this comment.
auto spell typo? contact == concat
Sorry, something went wrong.
There was a problem hiding this comment.
Yep... I edited. :)
Sorry, something went wrong.
|
Who wants to step in and finish this work? It seems the original author is not able to finish it. If no one steps in, we'll have to close the PR without merging it so please help :-). |
Sorry, something went wrong.
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#508 This closes apache#384 This closes apache#372
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#384 This closes apache#372
This closes apache#577 This closes apache#566 This closes apache#562 This closes apache#561 This closes apache#556 This closes apache#555 This closes apache#554 This closes apache#548 This closes apache#544 This closes apache#540 This closes apache#384 This closes apache#372
|
tag:vmware-pickup |
Sorry, something went wrong.
|
@likitha is this PR still pertinent? |
Sorry, something went wrong.
|
@jburwell Likitha has moved on, unlikely we'll hear from her or see further development activity |
Sorry, something went wrong.
|
This is open to long with no progress |
Sorry, something went wrong.
|
@DaanHoogland while this is open with no progress, can you check if the issue has been fixed or there exists a PR that works towards fixing the same. Let's not close old PRs that might still be useful. |
Sorry, something went wrong.
|
Continued with the code changes here in a new PR #2090. |
Sorry, something went wrong.
…sl certs (#540) Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Fixes apache#540 Using a simple hyphen as a delimiter for config cache key can lead to ambiguity if the “name” field itself contains hyphens. To address this, a Ternary object of configkey name, scope and scope ID is used as the config cache keys. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
…d partial unusable disks and VM snapshots in secondary storage.
Enhance storage garbage collector to delete corresponding partial disks created in secondary storage and VM snapshots while expunging 'ERROR' snapshot.