FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Privtmpl by pavanb018 · Pull Request #566 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

Privtmpl - #566

Closed
pavanb018 wants to merge 7 commits into
apache:masterfrom
pavanb018:privtmpl
ConversationCommits (7)ChecksFiles changed
Closed

Privtmpl#566
pavanb018 wants to merge 7 commits into
apache:masterfrom
pavanb018:privtmpl

Conversation

pavanb018 commented Jul 8, 2015

Copy link
Copy Markdown
Contributor

Comments provided in PR 241 are addressed and the commits for those are in this PR.

asfbot commented Jul 8, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #17 FAILURE
Looks like there's a problem with this pull request

DaanHoogland commented Jul 8, 2015

Copy link
Copy Markdown
Contributor

@pavanb018 You will have to add license headers to the new files

asfbot commented Jul 8, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #712 SUCCESS
This pull request looks good

asfbot commented Jul 8, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #19 SUCCESS
This pull request looks good

asfbot commented Jul 8, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #714 SUCCESS
This pull request looks good

pavanb018 commented Jul 8, 2015

Copy link
Copy Markdown
Contributor Author

test_project_private_template (integration.component.test_project_template.TestProjectPrivateTemplate) ... === TestName: test_project_private_template | Status : SUCCESS ===
ok

Ran 1 test in 216.074s

OK

pavanb018 commented Jul 8, 2015

Copy link
Copy Markdown
Contributor Author

On Basic Zone:

Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags | Status : SUCCESS ===
ok

Ran 1 test in 34.365s

OK

pavanb018 commented Jul 8, 2015

Copy link
Copy Markdown
Contributor Author

On Advanced Zone:

Test Deploy Virtual Machine ... === TestName: test_deploy_vm_with_tags | Status : SUCCESS ===
ok

Ran 1 test in 120.020s

OK

nitt10prashant reviewed Jul 8, 2015
View reviewed changes
Comment thread test/integration/component/test_project_template.py Outdated

nitt10prashant Jul 8, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

use validate list to validate list_volumes

asfbot commented Jul 8, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #20 SUCCESS
This pull request looks good

asfbot commented Jul 8, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #21 SUCCESS
This pull request looks good

asfbot commented Jul 8, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #715 SUCCESS
This pull request looks good

asfbot commented Jul 8, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #716 SUCCESS
This pull request looks good

wido commented Jul 17, 2015

Copy link
Copy Markdown
Contributor

I think it looks good? But it depends on earlier PR's I think since it's only a test

remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
Closing PRs older than a month without activity
8ade5dc 
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#508
This closes apache#384
This closes apache#372
remibergsma mentioned this pull request Aug 17, 2015
Closed
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
Closing PRs older than a month without activity
aa193a5 
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372
remibergsma added a commit to remibergsma/cloudstack that referenced this pull request Aug 17, 2015
Closing PRs older than a month without activity
7d28b3d 
This closes apache#577
This closes apache#566
This closes apache#562
This closes apache#561
This closes apache#556
This closes apache#555
This closes apache#554
This closes apache#548
This closes apache#544
This closes apache#540
This closes apache#384
This closes apache#372

rodrigo93 commented Jan 24, 2016

Copy link
Copy Markdown
Contributor

Why does this PR still open? Shouldn't be closed? Seems that has been resolved already...

pavanb018 closed this Apr 21, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL