FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

server: allow disk offering selection for volume from snapshot by shwstppr · Pull Request #3246 · apache/cloudstack · GitHub

  1. apache
  2. cloudstack

Repository navigation

server: allow disk offering selection for volume from snapshot - #3246

Merged
yadvr merged 5 commits into
apache:masterfrom
shapeblue:volume_from_snap_offering_support
Jun 25, 2019
ConversationCommits (5)ChecksFiles changed
Merged

server: allow disk offering selection for volume from snapshot#3246
yadvr merged 5 commits into
apache:masterfrom
shapeblue:volume_from_snap_offering_support

Conversation

shwstppr commented Mar 28, 2019 •
edited by borisstoyanov
Loading

Copy link
Copy Markdown
Contributor

Description

Problem: Volume created from a snapshot does not show its disk offering.

Root Cause: The volume created from a snapshot of a root disk does not have a disk offering therefore the disk offering of the created volume from the snapshot is empty.

Solution: Refactored createVolume API and extended UI to allow user to select a disk offering while creating a volume using a root disk volume snapshot. For creating volumes using data disk volume snapshot, the disk offering given by the snapshot will be assigned. Disk offering selection in the UI form for volume creation from snapshot is depicted in screenshot below.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

From UI

server: allow disk offering selection for volume from snapshot
3906dad 
Snapshots created for ROOT disk does not have disk offering id therefore when volume is created from them resulting volume also doesn't have any disk offering. This change allows selection of disk offering in UI when creating volumes from such snapshots.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr mentioned this pull request Mar 28, 2019
Closed
3 of 5 tasks

borisstoyanov commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Apr 5, 2019

Copy link
Copy Markdown

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Apr 5, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2683

borisstoyanov commented Apr 5, 2019

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Apr 5, 2019

Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan commented Apr 5, 2019

Copy link
Copy Markdown

Trillian test result (tid-3476)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25091 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3476-kvm-centos7.zip
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

borisstoyanov approved these changes Apr 8, 2019
View reviewed changes

borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, manually checked

yadvr commented May 23, 2019

Copy link
Copy Markdown
Member

@blueorangutan package

blueorangutan commented May 23, 2019

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented May 23, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2770

yadvr commented May 24, 2019

Copy link
Copy Markdown
Member

@blueorangutan test centos7 vmware-65u2

blueorangutan commented May 24, 2019

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

blueorangutan commented May 24, 2019

Copy link
Copy Markdown

Trillian test result (tid-3580)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49407 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3580-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_rvpc_multi_tiers Failure 594.30 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 640.28 test_vpc_redundant.py

yadvr added this to the 4.13.0.0 milestone May 27, 2019
ui: fix for extra diskofferingid param for data disk snaps to volume
bf4e50b 
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

shwstppr commented Jun 13, 2019

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

blueorangutan commented Jun 13, 2019

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jun 13, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2887

borisstoyanov commented Jun 17, 2019

Copy link
Copy Markdown
Contributor

@blueorangutan test

blueorangutan commented Jun 17, 2019

Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov approved these changes Jun 17, 2019
View reviewed changes

borisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, attached test results
test-results.xlsx

blueorangutan commented Jun 17, 2019

Copy link
Copy Markdown

Trillian test result (tid-3693)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29473 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3693-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

shwstppr and others added 3 commits June 20, 2019 16:41
ui: fix for allowing volume creation without offering
53d006b 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
server: added disk offering size check for volume creation from snapshot
8948344 
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
ui: revert 53d006b
b76e6c5 
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

borisstoyanov commented Jun 21, 2019

Copy link
Copy Markdown
Contributor

@blueorangutan package

blueorangutan commented Jun 21, 2019

Copy link
Copy Markdown

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan commented Jun 21, 2019

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2921

yadvr commented Jun 25, 2019

Copy link
Copy Markdown
Member

@blueorangutan test

blueorangutan commented Jun 25, 2019

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr changed the title [WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot server: allow disk offering selection for volume from snapshot Jun 25, 2019

yadvr commented Jun 25, 2019

Copy link
Copy Markdown
Member

This can be merged as soon as the tests are in and are OK.

blueorangutan commented Jun 25, 2019

Copy link
Copy Markdown

Trillian test result (tid-11)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t11-kvm-centos7.zip
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

yadvr merged commit 1b79466 into apache:master Jun 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yadvr yadvr approved these changes
nvazquez nvazquez approved these changes
borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL