server: allow disk offering selection for volume from snapshot - #34
Closed
shwstppr wants to merge 1 commit into
Closed
shwstppr wants to merge 1 commit into
shwstppr wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Snapshots created for ROOT disk does not have disk offering id therefore when volume is created from them resulting volume also doesn't have any disk offering. This change allows selection of disk offering in UI when creating volumes from such snapshots. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
1 of 5 tasks
yadvr
pushed a commit
that referenced
this pull request
Jan 20, 2021
* Stop emitting lint errors as warnings * Execute lint on inital serve for development * Fix linting errors * Fix linting warnings Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr
added a commit
that referenced
this pull request
Aug 16, 2021
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> ui: fix UI label bug #28 (#34) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> fix system vm migration with zone wide storage (#35) * fix system vm migration with zone wide storage Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix spacing Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * add empty volumes check Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> fix fr568 issue #28 (#36) Fixes systemvm migration with zone-wide storage Check only for usable volumes Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> vmware: fix error msg for vmotion without shared storage (#37) Fixes error message which wrongly mentions worker VM Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> refactor error message for interpod systemvm migration (#38) Fixes error message introduced in #28 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr
added a commit
that referenced
this pull request
Nov 23, 2021
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> ui: fix UI label bug #28 (#34) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> fix system vm migration with zone wide storage (#35) * fix system vm migration with zone wide storage Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix spacing Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * add empty volumes check Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> fix fr568 issue #28 (#36) Fixes systemvm migration with zone-wide storage Check only for usable volumes Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> vmware: fix error msg for vmotion without shared storage (#37) Fixes error message which wrongly mentions worker VM Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> refactor error message for interpod systemvm migration (#38) Fixes error message introduced in #28 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: Volume created from a snapshot does not show its disk offering.
Root Cause: The volume created from a snapshot of a root disk does not have a disk offering therefore the disk offering of the created volume from the snapshot is empty.
Solution: Refactored createVolume API and extended UI to allow user to select disk offering while creating volumes using a root disk volume snapshot. For creating volumes using data disk volume snapshot, disk offering given by snapshot will be assigned. Disk offering selection in UI form volume creation from snapshot is depicted in screenshot below.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
From UI