Add local ISO upload via UI - #35
Closed
nvazquez wants to merge 1 commit into
Closed
nvazquez wants to merge 1 commit into
nvazquez wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
yadvr
reviewed
Mar 25, 2019
Comment thread
ui/scripts/templates.js
Resolved
yadvr
approved these changes
Mar 25, 2019
Copy link
Copy Markdown
|
@nvazquez please send this to apache/cloudstack when you've time. Thanks. |
Sorry, something went wrong.
nvazquez
force-pushed
the
addlocalisoupload
branch
from
eff96dd to
24750aa
Compare
April 1, 2019 11:39
Copy link
Copy Markdown
Member
Author
|
Closing PR, moved to apache/master: apache/#3251 |
Sorry, something went wrong.
shwstppr
added a commit
that referenced
this pull request
Aug 16, 2021
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> ui: fix UI label bug #28 (#34) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> fix system vm migration with zone wide storage (#35) * fix system vm migration with zone wide storage Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix spacing Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * add empty volumes check Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> fix fr568 issue #28 (#36) Fixes systemvm migration with zone-wide storage Check only for usable volumes Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> vmware: fix error msg for vmotion without shared storage (#37) Fixes error message which wrongly mentions worker VM Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> refactor error message for interpod systemvm migration (#38) Fixes error message introduced in #28 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
shwstppr
added a commit
that referenced
this pull request
Nov 23, 2021
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> ui: fix UI label bug #28 (#34) Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> fix system vm migration with zone wide storage (#35) * fix system vm migration with zone wide storage Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * fix spacing Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * add empty volumes check Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> fix fr568 issue #28 (#36) Fixes systemvm migration with zone-wide storage Check only for usable volumes Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> vmware: fix error msg for vmotion without shared storage (#37) Fixes error message which wrongly mentions worker VM Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> refactor error message for interpod systemvm migration (#38) Fixes error message introduced in #28 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: Users can register ISOs from URL but cannot upload local ISOs.
Root cause: CloudStack provides browser-based upload support for volumes and templates, but ISOs are not supported.
Solution:
The existing browser-based upload from local functionality for templates and volumes (https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=39620237) is extended to support uploading local ISOs.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Templates tab -> ISOs -> Upload from local -> Select file on local file system