Repository navigation
Make the API documentation version not *hardcoded* to v4.9.0 - #3247
Merged
yadvr merged 2 commits intoMar 29, 2019
Merged
yadvr merged 2 commits into
yadvr merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
GabrielBrascher
requested review from
PaulAngus,
borisstoyanov,
pdion891,
rafaelweingartner,
wido and
yadvr
March 28, 2019 14:25
rafaelweingartner
approved these changes
Mar 28, 2019
Comment thread
tools/apidoc/generatecommands.xsl
Outdated
| <!-- Modify this line for the release version --> | ||
| <span> | ||
| Apache CloudStack v4.9.0 Root Admin API Reference | ||
| Apache CloudStack v%ACS_RELEASE% Root Admin API Reference |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
do we need/want the v? It is always v anyways.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Good point. I agree with you @rafaelweingartner. Updated it!
Sorry, something went wrong.
GabrielBrascher
force-pushed
the
generate-api-documentation-versioned
branch
2 times, most recently
from
6f71d58 to
94593f8
Compare
March 28, 2019 17:31
This commit makes the API documentation automatically updated to the current project version. If one wants to set another version, it is possible by just editing the ACS_RELEASE variable in 'build-apidoc.sh'.
GabrielBrascher
force-pushed
the
generate-api-documentation-versioned
branch
from
94593f8 to
7368cc0
Compare
March 28, 2019 17:32
yadvr
approved these changes
Mar 29, 2019
pbankonier
pushed a commit
to pbankonier/cloudstack
that referenced
this pull request
Apr 24, 2019
…apache#3247) This commit makes the API documentation automatically updated to the current project version. If one wants to set another version, it is possible by just editing the ACS_RELEASE variable in 'build-apidoc.sh'.
5 tasks
1 of 5 tasks
yadvr
pushed a commit
that referenced
this pull request
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the API documentation is hardcoded to v4.9.0. This commit makes the API documentation automatically updated to the current project version. If one wants to set another version, it is possible by just editing the ACS_RELEASE variable in build-apidoc.sh.
Description
Types of changes
Screenshots (if appropriate):
Prior to the changes proposed in this PR the generated API documentaion was labeled as '4.9.0':
How Has This Been Tested?
Project API documentation page:
Example of an API command documentation page:
