Repository navigation
Fix sed command failure in Mac OS. - #4253
Merged
yadvr merged 1 commit intoAug 10, 2020
Merged
yadvr merged 1 commit into
yadvr merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
DaanHoogland
approved these changes
Aug 8, 2020
DaanHoogland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nice @soreana , i forgot about this ;) lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Packaging result: ✔centos7 ✔debian. JID-1690 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM travis and build (on Linux) passes |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
apidoc build failed in Mac OS because of sed in-place command. It is a minor change that fixed this issue. More information here
Fixes: #3247
Fixes: #3312
Types of changes
How Has This Been Tested?
I tested this feature in Mac and Ubuntu